Use inclusive naming #7156
Merged
Use inclusive naming #7156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreYang
previously approved these changes
Jul 20, 2020
| @@ -15,6 +15,7 @@ | |||
| CHECK_NAME = 'envoy' | |||
|
|
|||
|
|
|||
| @pytest.mark.integration | |||
There was a problem hiding this comment.
Should we put integration and unit tests in separate files ?
There was a problem hiding this comment.
probably, but out of scope for this PR, in any case they can be run separately with -m integration or -m unit
AlexandreYang
changed the title
Merged
AlexandreYang
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.