Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use external LibLZ4, detected using standard pkg-config (ME-768) #7

Merged
merged 5 commits into from
Dec 9, 2019
Merged

Use external LibLZ4, detected using standard pkg-config (ME-768) #7

merged 5 commits into from
Dec 9, 2019

Conversation

j-vizcaino
Copy link

@j-vizcaino j-vizcaino commented Dec 5, 2019 •
edited
Loading

Related to https://github.com/DataDog/devtools/pull/1749

Note that updating liblz4 to v1.9.2 triggers deprecation warnings on build

# github.com/DataDog/dd-go/vendor/github.com/DataDog/golz4
cgo-gcc-prolog: In function '_cgo_531a5531b321_Cfunc_LZ4_compress_limitedOutput':
cgo-gcc-prolog:81:2: warning: 'LZ4_compress_limitedOutput' is deprecated (declared at /usr/local/include/lz4.h:687): use LZ4_compress_default() instead [-Wdeprecated-declarations]
# github.com/DataDog/dd-go/vendor/github.com/DataDog/golz4
cgo-gcc-prolog: In function '_cgo_531a5531b321_Cfunc_LZ4_compressHC2_limitedOutput':
cgo-gcc-prolog:58:2: warning: 'LZ4_compressHC2_limitedOutput' is deprecated (declared at /usr/local/include/lz4hc.h:284): use LZ4_compress_HC() instead [-Wdeprecated-declarations]

@j-vizcaino j-vizcaino requested a review from jmoiron December 5, 2019 17:09
@jmoiron
Copy link

jmoiron commented Dec 5, 2019

Presumably this now requires an external package to work; can we provide some build instructions for ubuntu/deb, OSX, and from-source in the readme?

@j-vizcaino j-vizcaino mentioned this pull request Dec 5, 2019
Closed
@j-vizcaino j-vizcaino force-pushed the jerome.v/switch-to-external-liblz4 branch 2 times, most recently from 654e787 to 62a7930 Compare December 6, 2019 22:04
@j-vizcaino j-vizcaino force-pushed the jerome.v/switch-to-external-liblz4 branch 6 times, most recently from 6f911b8 to d4a08aa Compare December 6, 2019 22:49
@j-vizcaino j-vizcaino force-pushed the jerome.v/switch-to-external-liblz4 branch from d4a08aa to e94d666 Compare December 6, 2019 22:55
@j-vizcaino j-vizcaino merged commit 9d8cd06 into master Dec 9, 2019
@j-vizcaino j-vizcaino deleted the jerome.v/switch-to-external-liblz4 branch December 9, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmoiron jmoiron jmoiron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-vizcaino @jmoiron