Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use external LibLZ4, detected using standard pkg-config (ME-768) #5

Closed
wants to merge 1 commit into from
Closed

Use external LibLZ4, detected using standard pkg-config (ME-768) #5

wants to merge 1 commit into from

Conversation

j-vizcaino
Copy link

@j-vizcaino j-vizcaino commented Dec 5, 2019 •
edited
Loading

Related to https://github.com/DataDog/devtools/pull/1749

Note that updating liblz4 triggers deprecation warnings on build

# github.com/DataDog/dd-go/vendor/github.com/DataDog/golz4
cgo-gcc-prolog: In function '_cgo_531a5531b321_Cfunc_LZ4_compress_limitedOutput':
cgo-gcc-prolog:81:2: warning: 'LZ4_compress_limitedOutput' is deprecated (declared at /usr/local/include/lz4.h:687): use LZ4_compress_default() instead [-Wdeprecated-declarations]
# github.com/DataDog/dd-go/vendor/github.com/DataDog/golz4
cgo-gcc-prolog: In function '_cgo_531a5531b321_Cfunc_LZ4_compressHC2_limitedOutput':
cgo-gcc-prolog:58:2: warning: 'LZ4_compressHC2_limitedOutput' is deprecated (declared at /usr/local/include/lz4hc.h:284): use LZ4_compress_HC() instead [-Wdeprecated-declarations]

@j-vizcaino j-vizcaino changed the title Use external LibLZ4, detected using standard pkg-config Use external LibLZ4, detected using standard pkg-config (ME-768) Dec 5, 2019
@j-vizcaino
Copy link
Author

Replaced by #7

@j-vizcaino j-vizcaino closed this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzzssss zzzzssss Awaiting requested review from zzzzssss

@jmoiron jmoiron Awaiting requested review from jmoiron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@j-vizcaino