Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Minor: Clean up output of profiler rspec execution #4084

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Nov 7, 2024

What does this PR do?

This PR tweaks rspec and some of the profiler tests so that running bundle exec rspec spec/datadog/profiling gets a clean output:

Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 34395
..........................................******..............................................................................*.*..................................................................**............**......*........*.....................*..............***.....*....*********.................******.............*..***********................*........................*.....**....*.....*.......................................................................................................................................................................*....**...*............................*..............................*..................................................................................................0.29.2
...


Finished in 14.4 seconds (files took 0.46237 seconds to load)
734 examples, 0 failures, 58 pending

Randomized with seed 34395

Motivation:

Make it easier to focus on failing specs, rather than on spec output noise.

Change log entry

(Does not impact customers)

Additional Notes:

N/A

How to test the change?

Validate that CI is still green + run the profiler test suite for yourself to see how the output is not noisy anymore!

As more and more skipped tests accumulate, this can get very noisy.

A bit like listing the full specs vs showing the dots progress, I've
tweaked the verbose skipped/pending specs list to only show up
selectively, when only a single file is being ran.
@ivoanjo ivoanjo requested review from a team as code owners November 7, 2024 13:02
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Nov 7, 2024
@ivoanjo ivoanjo added the dev/internal Other internal work that does not need to be included in the changelog label Nov 7, 2024
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM (looks clean to me)

@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2024

Benchmarks

Benchmark execution time: 2024-11-07 14:30:20

Comparing candidate commit 179046d in PR branch ivoanjo/profiling-specs-tweak with baseline commit 79fb090 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

@ivoanjo
Copy link
Member Author

ivoanjo commented Nov 7, 2024

Oopsie, looks like CI has not yet picked up the rspec 3.13 update that introduced this feature rspec/rspec-core#2957 . Let me fix that :)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (d7cd566) to head (179046d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4084      +/-   ##
==========================================
+ Coverage   97.72%   97.73%   +0.01%     
==========================================
  Files        1338     1338              
  Lines       80251    80259       +8     
  Branches     4017     4017              
==========================================
+ Hits        78428    78444      +16     
+ Misses       1823     1815       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivoanjo ivoanjo merged commit f679de4 into master Nov 7, 2024
149 of 167 checks passed
@ivoanjo ivoanjo deleted the ivoanjo/profiling-specs-tweak branch November 7, 2024 14:43
@github-actions github-actions bot added this to the 2.7.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants