-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO-TICKET] Minor: Clean up output of profiler rspec execution #4084
Conversation
As more and more skipped tests accumulate, this can get very noisy. A bit like listing the full specs vs showing the dots progress, I've tweaked the verbose skipped/pending specs list to only show up selectively, when only a single file is being ran.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LCTM (looks clean to me)
BenchmarksBenchmark execution time: 2024-11-07 14:30:20 Comparing candidate commit 179046d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. |
Oopsie, looks like CI has not yet picked up the rspec 3.13 update that introduced this feature rspec/rspec-core#2957 . Let me fix that :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4084 +/- ##
==========================================
+ Coverage 97.72% 97.73% +0.01%
==========================================
Files 1338 1338
Lines 80251 80259 +8
Branches 4017 4017
==========================================
+ Hits 78428 78444 +16
+ Misses 1823 1815 -8 ☔ View full report in Codecov by Sentry. |
What does this PR do?
This PR tweaks rspec and some of the profiler tests so that running
bundle exec rspec spec/datadog/profiling
gets a clean output:Motivation:
Make it easier to focus on failing specs, rather than on spec output noise.
Change log entry
(Does not impact customers)
Additional Notes:
N/A
How to test the change?
Validate that CI is still green + run the profiler test suite for yourself to see how the output is not noisy anymore!