Skip to content

Commit

Permalink
Merge pull request #4083 from DataDog/lloeki/reenable-crashtracker-by…
Browse files Browse the repository at this point in the history
…-default

Revert "Disable crashtracking by default"
  • Loading branch information
lloeki authored Nov 7, 2024
2 parents d7cd566 + 6b6e884 commit 79fb090
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/datadog/core/configuration/settings.rb
Original file line number Diff line number Diff line change
Expand Up @@ -927,7 +927,7 @@ def initialize(*_)
# Enables reporting of information when Ruby VM crashes.
option :enabled do |o|
o.type :bool
o.default false
o.default true
o.env 'DD_CRASHTRACKING_ENABLED'
end
end
Expand Down
6 changes: 3 additions & 3 deletions spec/datadog/core/configuration/settings_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2075,7 +2075,7 @@
context 'is not defined' do
let(:environment) { nil }

it { is_expected.to be false }
it { is_expected.to be true }
end

[true, false].each do |value|
Expand All @@ -2090,9 +2090,9 @@

describe '#enabled=' do
it 'updates the #enabled setting' do
expect { settings.crashtracking.enabled = true }
expect { settings.crashtracking.enabled = false }
.to change { settings.crashtracking.enabled }
.from(false).to(true)
.from(true).to(false)
end
end
end
Expand Down

0 comments on commit 79fb090

Please sign in to comment.