Revert "Disable crashtracking by default"

[lloeki]

What does this PR do?

This reverts commit c8a2165 from #3970

Motivation:

#4082 fixed the root cause.

Change log entry

Default crashtracking to enabled.

Additional Notes:

How to test the change?

CI

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (d7cd566) to head (6b6e884).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4083      +/-   ##
==========================================
+ Coverage   97.72%   97.73%   +0.01%     
==========================================
  Files        1338     1338              
  Lines       80251    80251              
  Branches     4017     4017              
==========================================
+ Hits        78428    78437       +9     
+ Misses       1823     1814       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-11-07 12:12:10

Comparing candidate commit 6b6e884 in PR branch lloeki/reenable-crashtracker-by-default with baseline commit d7cd566 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 27 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

• 🟥 throughput [-0.724op/s; -0.716op/s] or [-10.546%; -10.425%]

scenario:profiler - stack collector

• 🟥 throughput [-238.942op/s; -237.283op/s] or [-8.063%; -8.007%]

[ivoanjo]

👍 LGTM. Peeking at #3970, I think it would be nice to also re-add the "ensures the latest configuration applied" spec, since it was adding coverage for a non-trivial bug that almost got in when we changed crashtracker to be independent from profiling.