Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fastapi.yml and updated django and flask #2363

Merged
merged 28 commits into from
Apr 30, 2021
Merged
Changes from 10 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
fb8eb2e
added fastapi.yml and updated django and flask
Apr 27, 2021
3c224e9
Fixed failing tests, added ddtrace-run to run command, reverted chang…
Apr 27, 2021
4abeb54
changed run command
Apr 27, 2021
c5a068c
fixed pydantic dependencies
Apr 27, 2021
ec77498
added new dependency typing
Apr 27, 2021
5386ecb
changed from Flit to tox using flask.yml's run command. Testing to se…
Apr 27, 2021
a0fbacc
reverted to flit. changed run command
Apr 27, 2021
5f13561
new changes
Apr 27, 2021
66e6173
updated mypy to latest version to see if it clears our errors
Apr 27, 2021
b9bbe84
updated mypy to latest version to see if it clears our errors test 2
Apr 27, 2021
1c46925
removed the bash script run command and replaced it with pytest
Apr 28, 2021
1006b35
downgraded sqlalchemy to fix errors
Apr 28, 2021
de27ec0
changed ddtrace install command
Apr 28, 2021
a1b7cfc
removed install of typing module
Apr 28, 2021
74d1bf8
Merge branch 'master' into fastapi
Yun-Kim Apr 28, 2021
282d3ff
Merge branch 'master' into fastapi
Genegrady Apr 29, 2021
fcb3a4e
Merge branch 'master' into fastapi
Genegrady Apr 29, 2021
7cb8d37
Changed the version of python being tested to just 3.9
Apr 29, 2021
e9595d7
Merge branch 'fastapi' of github.com:DataDog/dd-trace-py into fastapi
Apr 29, 2021
fd12d9b
Merge branch 'master' into fastapi
Genegrady Apr 29, 2021
7932278
Update .github/workflows/fastapi.yml
Genegrady Apr 29, 2021
c78219f
added comments
Apr 29, 2021
8196f9c
Merge branch 'fastapi' of github.com:DataDog/dd-trace-py into fastapi
Apr 29, 2021
fb08404
updated comments
Apr 29, 2021
08a7223
Merge branch 'master' into fastapi
Genegrady Apr 30, 2021
6402418
Merge branch 'master' into fastapi
mergify[bot] Apr 30, 2021
b6aa092
Merge branch 'master' into fastapi
mergify[bot] Apr 30, 2021
68a3760
Merge branch 'master' into fastapi
Genegrady Apr 30, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/fastapi.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: fastapi-testsuite
on:
push:
branches:
- master
pull_request:
jobs:
fastapi-test:
runs-on: ubuntu-latest
defaults:
run:
working-directory: fastapi
strategy:
matrix:
python-version: [3.6, 3.7, 3.8, 3.9]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think I'll echo a previous comment, we can probably just test 1 version of Python, since FastAPI is testing that they are compatible with all of these versions, we just need to be sure we are compatible with FastAPI

(unless our instrumentation has a bunch of python version conditionals?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brettlangdon Sounds good. I will change the conditional to the latest version (3.9)

fail-fast: false
steps:
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- uses: actions/checkout@v2
with:
path: ddtrace
- uses: actions/checkout@v2
with:
repository: tiangolo/fastapi
ref: 0.63.0
path: fastapi
- name: Install Flit
run: pip install flit
- name: Install Dependencies
run: flit install --symlink
- name: update mypy
run: pip install --upgrade --force-reinstall mypy
- name: Install Typing
run: pip install typing
- name: Inject ddtrace
run: pip install ddtrace
Yun-Kim marked this conversation as resolved.
Show resolved Hide resolved
- name: Test
run: ddtrace-run scripts/test.sh
Genegrady marked this conversation as resolved.
Show resolved Hide resolved