-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added fastapi.yml and updated django and flask #2363
Merged
Merged
Changes from 10 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
fb8eb2e
added fastapi.yml and updated django and flask
3c224e9
Fixed failing tests, added ddtrace-run to run command, reverted chang…
4abeb54
changed run command
c5a068c
fixed pydantic dependencies
ec77498
added new dependency typing
5386ecb
changed from Flit to tox using flask.yml's run command. Testing to se…
a0fbacc
reverted to flit. changed run command
5f13561
new changes
66e6173
updated mypy to latest version to see if it clears our errors
b9bbe84
updated mypy to latest version to see if it clears our errors test 2
1c46925
removed the bash script run command and replaced it with pytest
1006b35
downgraded sqlalchemy to fix errors
de27ec0
changed ddtrace install command
a1b7cfc
removed install of typing module
74d1bf8
Merge branch 'master' into fastapi
Yun-Kim 282d3ff
Merge branch 'master' into fastapi
Genegrady fcb3a4e
Merge branch 'master' into fastapi
Genegrady 7cb8d37
Changed the version of python being tested to just 3.9
e9595d7
Merge branch 'fastapi' of github.com:DataDog/dd-trace-py into fastapi
fd12d9b
Merge branch 'master' into fastapi
Genegrady 7932278
Update .github/workflows/fastapi.yml
Genegrady c78219f
added comments
8196f9c
Merge branch 'fastapi' of github.com:DataDog/dd-trace-py into fastapi
fb08404
updated comments
08a7223
Merge branch 'master' into fastapi
Genegrady 6402418
Merge branch 'master' into fastapi
mergify[bot] b6aa092
Merge branch 'master' into fastapi
mergify[bot] 68a3760
Merge branch 'master' into fastapi
Genegrady File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
name: fastapi-testsuite | ||
on: | ||
push: | ||
branches: | ||
- master | ||
pull_request: | ||
jobs: | ||
fastapi-test: | ||
runs-on: ubuntu-latest | ||
defaults: | ||
run: | ||
working-directory: fastapi | ||
strategy: | ||
matrix: | ||
python-version: [3.6, 3.7, 3.8, 3.9] | ||
fail-fast: false | ||
steps: | ||
- name: Set up Python | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- uses: actions/checkout@v2 | ||
with: | ||
path: ddtrace | ||
- uses: actions/checkout@v2 | ||
with: | ||
repository: tiangolo/fastapi | ||
ref: 0.63.0 | ||
path: fastapi | ||
- name: Install Flit | ||
run: pip install flit | ||
- name: Install Dependencies | ||
run: flit install --symlink | ||
- name: update mypy | ||
run: pip install --upgrade --force-reinstall mypy | ||
- name: Install Typing | ||
run: pip install typing | ||
- name: Inject ddtrace | ||
run: pip install ddtrace | ||
Yun-Kim marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- name: Test | ||
run: ddtrace-run scripts/test.sh | ||
Genegrady marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think I'll echo a previous comment, we can probably just test 1 version of Python, since FastAPI is testing that they are compatible with all of these versions, we just need to be sure we are compatible with FastAPI
(unless our instrumentation has a bunch of python version conditionals?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brettlangdon Sounds good. I will change the conditional to the latest version (3.9)