added fastapi.yml and updated django and flask #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majorgreys
reviewed
Apr 27, 2021
added 8 commits
April 27, 2021 13:00
…e what errors come in
Genegrady
added
the
changelog/no-changelog
Yun-Kim
reviewed
Apr 28, 2021
.github/workflows/fastapi.yml
Outdated
| working-directory: fastapi | ||
| strategy: | ||
| matrix: | ||
| python-version: [3.6, 3.7, 3.8, 3.9] |
There was a problem hiding this comment.
think I'll echo a previous comment, we can probably just test 1 version of Python, since FastAPI is testing that they are compatible with all of these versions, we just need to be sure we are compatible with FastAPI
(unless our instrumentation has a bunch of python version conditionals?)
There was a problem hiding this comment.
@brettlangdon Sounds good. I will change the conditional to the latest version (3.9)
Yun-Kim
reviewed
Apr 29, 2021
Co-authored-by: Yun Kim <[email protected]>
Yun-Kim
reviewed
Apr 29, 2021
.github/workflows/fastapi.yml
Outdated
Comment on lines
25
to
30
| - name: Install Flit | ||
| run: pip install flit | ||
| - name: Install Dependencies | ||
| run: flit install --symlink | ||
| - name: Downgrade SQLalchemy | ||
| run: pip install --force-reinstall SQLAlchemy==1.3.24 |
There was a problem hiding this comment.
It would be nice if you could add a quick comment above each of these these steps to label as being fastapi specific, and maybe explain why these steps are necessary to provide some context in the future 😄
Genegrady
commented
Apr 29, 2021
brettlangdon
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist