Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddtrace/tracer: Report datadog.tracer.queue.enqueued.traces as health metric #3019

Merged
merged 6 commits into from
Dec 20, 2024
Merged

ddtrace/tracer: Report datadog.tracer.queue.enqueued.traces as health metric #3019

merged 6 commits into from
Dec 20, 2024

Conversation

mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Dec 9, 2024

What does this PR do?

Reports the number of traces in the queue at a specified interval.
NOTE: This implementation does not currently differentiate between true "traces" and partial trace "chunks"

Motivation

Report more data from our health metrics

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@mtoffl01 mtoffl01 marked this pull request as ready for review December 10, 2024 20:21
@mtoffl01 mtoffl01 requested a review from a team as a code owner December 10, 2024 20:21
@mtoffl01 mtoffl01 requested a review from hannahkm December 10, 2024 20:21
@pr-commenter
Copy link

pr-commenter bot commented Dec 16, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-12-20 15:36:04

Comparing candidate commit 3036c2b in PR branch mtoff/health-metrics with baseline commit 637ea72 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 18, 2024 •
edited
Loading

Datadog Report

Branch report: mtoff/health-metrics
Commit report: db84485
Test service: dd-trace-go

✅ 0 Failed, 5117 Passed, 70 Skipped, 2m 33.34s Total Time

@mtoffl01 mtoffl01 marked this pull request as draft December 19, 2024 16:01
@mtoffl01 mtoffl01 marked this pull request as ready for review December 20, 2024 14:52
@mtoffl01 mtoffl01 merged commit d393324 into main Dec 20, 2024
159 of 160 checks passed
@mtoffl01 mtoffl01 deleted the mtoff/health-metrics branch December 20, 2024 15:49
e-n-0 pushed a commit that referenced this pull request Dec 23, 2024
@mtoffl01 @e-n-0
ddtrace/tracer: Report datadog.tracer.queue.enqueued.traces as health…
7118aeb 
… metric (#3019)
e-n-0 added a commit that referenced this pull request Dec 23, 2024
@e-n-0
Applied comments (ipenv, signals, gracefull shutdown)
206b21a 
Applied comments

appsec: stop storing span tags, directly call span.SetTag (#3044)

Signed-off-by: Eliott Bouhana <[email protected]>

ddtrace/tracer: Tracing as transport-only mode (APPSEC_STANDALONE) (#3033)

Signed-off-by: Eliott Bouhana <[email protected]>

fix: improving test logic for TestStreamSendsErrorCode to avoid flakiness (#3049)

vuln: upgrade golang.org/x/{crypto,net} to non-vulnerable versions (#3050)

contrib/miekg/dns: resolve flaky test in TestExchange* (#3045)

ddtrace/tracer: report datadog.tracer.api.errors health metric (#3024)

build(deps): bump google.golang.org/grpc from 1.64.0 to 1.64.1 (#3001)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Argüello <[email protected]>

ddtrace/tracer: Report datadog.tracer.queue.enqueued.traces as health metric (#3019)

ddtrace/tracer: Tracing as transport-only mode (APPSEC_STANDALONE) (#3033)

Signed-off-by: Eliott Bouhana <[email protected]>

fix: improving test logic for TestStreamSendsErrorCode to avoid flakiness (#3049)

vuln: upgrade golang.org/x/{crypto,net} to non-vulnerable versions (#3050)

contrib/miekg/dns: resolve flaky test in TestExchange* (#3045)

ddtrace/tracer: report datadog.tracer.api.errors health metric (#3024)

build(deps): bump google.golang.org/grpc from 1.64.0 to 1.64.1 (#3001)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Argüello <[email protected]>

ddtrace/tracer: Report datadog.tracer.queue.enqueued.traces as health metric (#3019)
e-n-0 added a commit that referenced this pull request Dec 23, 2024
@e-n-0
Applied comments (ipenv, signals, gracefull shutdown)
d6dda03 
Applied comments

appsec: stop storing span tags, directly call span.SetTag (#3044)

Signed-off-by: Eliott Bouhana <[email protected]>

ddtrace/tracer: Tracing as transport-only mode (APPSEC_STANDALONE) (#3033)

Signed-off-by: Eliott Bouhana <[email protected]>

fix: improving test logic for TestStreamSendsErrorCode to avoid flakiness (#3049)

vuln: upgrade golang.org/x/{crypto,net} to non-vulnerable versions (#3050)

contrib/miekg/dns: resolve flaky test in TestExchange* (#3045)

ddtrace/tracer: report datadog.tracer.api.errors health metric (#3024)

build(deps): bump google.golang.org/grpc from 1.64.0 to 1.64.1 (#3001)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Argüello <[email protected]>

ddtrace/tracer: Report datadog.tracer.queue.enqueued.traces as health metric (#3019)

ddtrace/tracer: Tracing as transport-only mode (APPSEC_STANDALONE) (#3033)

Signed-off-by: Eliott Bouhana <[email protected]>

fix: improving test logic for TestStreamSendsErrorCode to avoid flakiness (#3049)

vuln: upgrade golang.org/x/{crypto,net} to non-vulnerable versions (#3050)

contrib/miekg/dns: resolve flaky test in TestExchange* (#3045)

ddtrace/tracer: report datadog.tracer.api.errors health metric (#3024)

build(deps): bump google.golang.org/grpc from 1.64.0 to 1.64.1 (#3001)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Argüello <[email protected]>

ddtrace/tracer: Report datadog.tracer.queue.enqueued.traces as health metric (#3019)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahkm hannahkm hannahkm approved these changes

@darccio darccio darccio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtoffl01 @darccio @hannahkm