[network] dont combine connection states #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmmeyer
force-pushed
the
greg/split_connection_types
branch
from
116111d to
f8cc837
Compare
olivielpeau
reviewed
Feb 2, 2017
| @@ -13,3 +13,6 @@ instances: | |||
| # Optionally completely ignore any network interface | |||
| # matching the given regex: | |||
| # excluded_interface_re: my-network-interface.* | |||
|
|
|||
| # Do not combine connection states | |||
There was a problem hiding this comment.
Could you add more details on what the option does? And I think it's worth explicitly mentioning what the default value is.
There was a problem hiding this comment.
That's a good note, thank you.
|
@olivielpeau I can add some tests, however we'll have to add them in integrations core, the changes to the file structure forced me to change the tests for this one pretty substantially :( |
olivielpeau
approved these changes
Feb 7, 2017
|
I'll put it in the issues there |
degemer
added a commit
that referenced
this pull request
Feb 7, 2017
* master: (67 commits) [network] dont combine connection states (#3158) renames function in line with other checks [couchbase] Modified service_check_tags in couchbase.py to include user-specified tags. (#3079) [docker] fix image tag extraction Fix tests, refactor how we collect container and volume states test_docker_daemon.py: fix syntax errors Beginning work on docker_daemon tests. Add 5 opt-in checks to docker_daemon add mention of office hours (#3171) updates psycopg2 to 2.6.2 (#3170) [trace-agent] adding output of 'trace-agent -info' (#3164) [riak] Change default value in configuration example to match default value from the code move setting parameter to instance level riak security support [dns_check][ci] Bring back assertions on metrics (#3162) [powerdns_recursor] adds support for v4. (#3166) [tcp_check] Add custom tags to response_time gauge catch can't connect instead of failing on nodata found (#3127) [php-fpm] add http_host tag [dns_check] Document NXDOMAIN usage in yaml example file ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supercedes #2856. It fixes the failing tests and puts the changes behind a flag.