dont combine connection states #2856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the contribution @joewilliams! First off, can you make sure to fix the tests that this breaks? Second, can you put this change behind a flag in the config file? We want to make sure to keep backwards compatibility. (I think the change is correct, but not everyone cares about the difference and we don't want to break anyone's setup.) Can you clarify whether this would supercede your changes from #2720 or if they're both needed? Thank you very much, again! I think this would be easily merged after these changes. 😄 |
|
Closing because this has been superseded by this PR: #3158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes the networking check to use the individual connection states rather than combine them. This PR is a more manageable version of #2720. We have our own
nstatbased plugin that does the extended TCP metrics included in that PR but would like to split connection states into their actual buckets.Motivation
It bugs me that the states are added together.