Fail2ban check

[brettlangdon]

Add a fail2ban check, which reports stats from fail2ban-client status <jail>

[brettlangdon]

tests seemed to have failed for python 2.6.9, I am using subprocess.check_output which was added in 2.7, will update to remove dependency on check_output

[brettlangdon]

ok... now looks like I have to replace assertDictEquals and assertDictContainsSubset

[brettlangdon]

it helps when I run the tests locally on python 2.6 :)

[remh]

Thanks a lot Brett! We'll review this for 5.4.0 !

[talwai]

AgentCheckTest is an unused import right now

[talwai]

Thanks for contributing @brettlangdon and sorry for the delay! Looks great overall, added a few comments on how you could modify your tests to use the standards we want to keep in the agent test suite going forward. I'd recommend looking at a test such as the go_expvar one in case the AgentCheckTest interface is unfamiliar to you. Let me know when you get a chance to look at this again

[brettlangdon]

👍 awesome, thanks for the review, ill gladly update the tests.
On Jul 27, 2015 10:02 PM, "Aaditya Talwai" [email protected] wrote:

Thanks for contributing @brettlangdon https://github.com/brettlangdon
and sorry for the delay! Looks great overall, added a few comments on how
you could modify your tests to use the standards we want to keep in the
agent test suite going forward. I'd recommend looking at a test such as the
go_expvar
https://github.com/DataDog/dd-agent/blob/aeef08d3d098ec3d6292cd8be2b106cb7a9b45ab/tests/checks/mock/test_go_expvar.py
one in case the AgentCheckTest interface is unfamiliar to you. Let me
know when you get a chance to look at this again

—
Reply to this email directly or view it on GitHub
#1427 (comment).

[brettlangdon]

@talwai I just updated the PR with updated test cases. Hopefully this is more in line with everything else. Let me know if I need to update anything else.

[talwai]

@brettlangdon yup, looks great! Merging this

[talwai]

@brettlangdon we actually had some issues with this check during integration testing for 5.5.0, particularly with needing to pass sudo passwords into the subprocess. We have to revert for now, unfortunately, so we can get the next release out the door, but we have it slated for 5.6.0!

Sorry about the confusion, I'll elaborate further on how we'd like to improve the check in the next few days.

[brettlangdon]

No problems, I understand, it is a little wonky with having to grant sudo access for datadog

[talwai]

Thanks for understanding. Would you mind reopening a PR from your fork so it can undergo further review? Github won't let us re-open this one since we already merged it ;)