Enable foreground tracking for everyone #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #961 +/- ##
==========================================
+ Coverage 89.08% 89.14% +0.06%
==========================================
Files 83 83
Lines 3866 3861 -5
Branches 857 856 -1
==========================================
- Hits 3444 3442 -2
+ Misses 422 419 -3
Continue to review full report at Codecov.
|
BenoitZugmeyer
approved these changes
Jul 27, 2021
ThibautGeriz
force-pushed
the
thibaut.gery/track-foreground-by-default
branch
from
bba4a58 to
0e57a68
Compare
bcaudan
reviewed
Aug 2, 2021
| @@ -60,10 +51,6 @@ function addNewForegroundPeriod() { | |||
| } | |||
| const currentForegroundPeriod = foregroundPeriods[foregroundPeriods.length - 1] | |||
| if (currentForegroundPeriod !== undefined && currentForegroundPeriod.end === undefined) { | |||
| addMonitoringMessage('Previous foreground periods not closed. Continuing current one', { | |||
There was a problem hiding this comment.
AFAIK, They are not triggered at the moment, I would like to know if we change something and those limit case start to trigger.
There was a problem hiding this comment.
By looking at the logs I shared with you earlier, we can see some occurrences for all of them.
…reground-by-default
|
Closed for #1053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enable foreground tracking for everyone
Changes
Remove experimental flag
I have gone over the contributing documentation.