Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove focus feature flag #1053

Merged
merged 3 commits into from
Sep 17, 2021
Merged

Remove focus feature flag #1053

merged 3 commits into from
Sep 17, 2021

Conversation

ThibautGeriz
Copy link
Contributor

Motivation

Activate foreground periods issue for all our user.

Analysis: https://docs.google.com/document/d/17FsROHTNE8hh_Ra6blCgNwyZn8m2PqRefS_WIWjfBSk/edit#

Changes

  • remove FF
  • remove monitoring

@ThibautGeriz ThibautGeriz requested a review from a team as a code owner September 15, 2021 13:28
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #1053 (50d813e) into main (f61c866) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
+ Coverage   89.01%   89.10%   +0.09%     
==========================================
  Files          87       87              
  Lines        4123     4112      -11     
  Branches      950      947       -3     
==========================================
- Hits         3670     3664       -6     
+ Misses        453      448       -5     
Impacted Files Coverage Δ
packages/rum-core/src/boot/startRum.ts 37.03% <100.00%> (ø)
packages/rum-core/src/domain/foregroundContexts.ts 90.76% <100.00%> (+5.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f61c866...50d813e. Read the comment docs.

@ThibautGeriz ThibautGeriz merged commit cbda6fb into main Sep 17, 2021
@ThibautGeriz ThibautGeriz deleted the thibaut.gery/remove-focus-ff branch September 17, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants