[RUMF-804] implement a minimal version of the recorder #670

BenoitZugmeyer · 2020-12-31T11:31:10Z

Previous PR: #658

Motivation

Implement a minimal version of the session replay recorder.

Changes

Testing

Unit tests + manual testing

I have gone over the contributing documentation.

packages/rum-recorder/src/boot/recorder.entry.ts

codecov-io · 2020-12-31T11:41:24Z

Codecov Report

Merging #670 (0dbceac) into master (2d8943a) will increase coverage by 1.36%.
The diff coverage is 91.51%.

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
+ Coverage   77.98%   79.35%   +1.36%     
==========================================
  Files          60       66       +6     
  Lines        3284     3434     +150     
  Branches      714      735      +21     
==========================================
+ Hits         2561     2725     +164     
+ Misses        723      709      -14

Impacted Files	Coverage Δ
packages/rum-core/src/boot/rum.ts	`50.00% <ø> (ø)`
packages/rum-core/src/rawRumEvent.types.ts	`100.00% <ø> (ø)`
packages/rum-recorder/src/domain/rrweb/observer.ts	`53.23% <0.00%> (+2.08%)`	⬆️
packages/rum-recorder/src/domain/rrweb/types.ts	`100.00% <ø> (ø)`
packages/rum-recorder/test/utils.ts	`93.54% <93.54%> (ø)`
packages/core/src/domain/configuration.ts	`91.13% <100.00%> (+0.47%)`	⬆️
packages/core/src/transport/transport.ts	`91.66% <100.00%> (ø)`
packages/rum-recorder/src/boot/recorder.ts	`100.00% <100.00%> (ø)`
...es/rum-recorder/src/domain/deflateSegmentWriter.ts	`100.00% <100.00%> (ø)`
packages/rum-recorder/src/domain/segment.ts	`100.00% <100.00%> (ø)`
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d8943a...0dbceac. Read the comment docs.

and add a recorder test

This dependency (only used for typings) was using `Set`, making the rum-recorder package requiring the es2015 typescript lib. This commit removes the dependency and replaces it with lighter typings.

sarina-dd

👍 docs

* inline 'trackSegmentRenewal' in 'segmentCollection' * move 'getSegmentContext' in 'segmentCollection' * extract 'Segment' in its own file * create workers and writers directly in 'segmentCollection'

This allows to simplify the Segment implementation.

packages/rum-recorder/src/domain/segmentCollection.ts

packages/rum-recorder/src/boot/recorder.spec.ts

packages/rum-recorder/src/domain/segmentCollection.ts

packages/rum-recorder/src/boot/recorder.spec.ts

packages/rum-recorder/src/domain/deflateWorker.js

packages/rum-recorder/src/domain/segmentCollection.ts

packages/rum-recorder/src/boot/recorder.spec.ts

bcaudan

Great job 👏

…corder

* [RUMF-804] implement the deflate worker * [RUMF-804] add sessionReplay endpoint support * [RUMF-804] implement segmentCollection * [RUMF-804] implement segment renewal tracking * [RUMF-804] implement DeflateSegmentWriter * [RUMF-804] implement the recorder entry point * ✅ [RUMF-804] add support for session replay in E2E tests and add a recorder test

…og#670)" This reverts commit 892ab5d.

BenoitZugmeyer requested review from a team as code owners December 31, 2020 11:31

BenoitZugmeyer changed the base branch from master to benoit/import-rrweb December 31, 2020 11:31

BenoitZugmeyer mentioned this pull request Dec 31, 2020

[RUMF-803] import RRWeb #658

Merged

BenoitZugmeyer commented Dec 31, 2020

View reviewed changes

packages/rum-recorder/src/boot/recorder.entry.ts Outdated Show resolved Hide resolved

BenoitZugmeyer force-pushed the benoit/implement-recorder branch 2 times, most recently from d09a1b6 to ab0ea49 Compare January 4, 2021 09:18

BenoitZugmeyer marked this pull request as draft January 4, 2021 10:34

BenoitZugmeyer force-pushed the benoit/implement-recorder branch 2 times, most recently from 252b249 to 0f028ba Compare January 4, 2021 11:38

BenoitZugmeyer force-pushed the benoit/import-rrweb branch from 88dc616 to 4ac2a09 Compare January 4, 2021 17:37

Base automatically changed from benoit/import-rrweb to master January 5, 2021 11:51

BenoitZugmeyer force-pushed the benoit/implement-recorder branch 5 times, most recently from 19a2bd3 to 2f2cbf6 Compare January 6, 2021 17:23

[RUMF-804] implement the deflate worker

964024e

BenoitZugmeyer force-pushed the benoit/implement-recorder branch from 71e2011 to 3981e01 Compare January 8, 2021 14:28

BenoitZugmeyer added 7 commits January 8, 2021 15:50

[RUMF-804] add sessionReplay endpoint support

00cd89e

[RUMF-804] implement segmentCollection

67cfd0f

[RUMF-804] implement segment renewal tracking

fbfa47d

[RUMF-804] implement DeflateSegmentWriter

79ef0b4

[RUMF-804] implement the recorder entry point

c4fc8ee

✅ [RUMF-804] add support for session replay in E2E tests

a52d702

and add a recorder test

🏷️ remove the @types/css-font-loading-module dependency

583a557

This dependency (only used for typings) was using `Set`, making the rum-recorder package requiring the es2015 typescript lib. This commit removes the dependency and replaces it with lighter typings.

BenoitZugmeyer force-pushed the benoit/implement-recorder branch from 3981e01 to 583a557 Compare January 8, 2021 14:50

BenoitZugmeyer marked this pull request as ready for review January 8, 2021 14:50

sarina-dd approved these changes Jan 8, 2021

View reviewed changes

👌✅ remove internal_ exports and replace with direct import

e4d0272

BenoitZugmeyer force-pushed the benoit/implement-recorder branch from f16dd3b to e4d0272 Compare January 13, 2021 11:55

BenoitZugmeyer added 8 commits January 14, 2021 12:02

👌🏗 improve recorder architecture

af31724

* inline 'trackSegmentRenewal' in 'segmentCollection' * move 'getSegmentContext' in 'segmentCollection' * extract 'Segment' in its own file * create workers and writers directly in 'segmentCollection'

👌 don't create a segment if the session is not tracked

9aeb990

🔥👌 remove mousemove batching logic

7ffabe9

👌 lazily create a segment on first record

4cdf7c5

This allows to simplify the Segment implementation.

👌 reword segment 'renew' to 'flush'

4f7b300

👌 reword 'complete' to 'flush'

a683424

📝👌 improve segmentCollection doc

ff0524d

👌 add doc and monitor log on lost worker response

58af718

bcaudan reviewed Jan 19, 2021

View reviewed changes

👌 add window.setTimeout to simplify typing

6e6e3f5

BenoitZugmeyer force-pushed the benoit/implement-recorder branch from 51c07b8 to 28be2f4 Compare January 19, 2021 11:20

BenoitZugmeyer added 6 commits January 19, 2021 15:07

✅👌 move waitRequests to the end of test cases

0e0b266

👌 rename 'doGetSegmentContext' to 'computeSegmentContext'

3425b84

✅👌 reword startRecording first test case

ae218f7

👌 add pako to thirdparty licenses

a0b86c3

👌 remove comments

dd557de

👌 rename visibility_change to visibility_reason

daf1360

BenoitZugmeyer force-pushed the benoit/implement-recorder branch from 28be2f4 to daf1360 Compare January 19, 2021 14:07

✅ try to make recorder tests less flacky

d67bb18

bcaudan reviewed Jan 20, 2021

View reviewed changes

packages/rum-recorder/src/boot/recorder.spec.ts Outdated Show resolved Hide resolved

👌✅ split waitRequests and expectNoExtraRequest to be more explicit

0dbceac

bcaudan approved these changes Jan 20, 2021

View reviewed changes

Merge remote-tracking branch 'origin/master' into benoit/implement-re…

45a7d0b

…corder

BenoitZugmeyer merged commit f7d8100 into master Jan 20, 2021

BenoitZugmeyer deleted the benoit/implement-recorder branch January 20, 2021 11:31

BenoitZugmeyer mentioned this pull request Jan 20, 2021

[RUM] add session.has_replay #687

Merged

kcaffrey added a commit to WonderInventions/browser-sdk that referenced this pull request Jan 29, 2021

Revert "[RUMF-804] implement a minimal version of the recorder (DataD…

8f6e3df

…og#670)" This reverts commit 892ab5d.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RUMF-804] implement a minimal version of the recorder #670

[RUMF-804] implement a minimal version of the recorder #670

BenoitZugmeyer commented Dec 31, 2020 •

edited

Loading

codecov-io commented Dec 31, 2020 •

edited

Loading

sarina-dd left a comment

bcaudan left a comment

[RUMF-804] implement a minimal version of the recorder #670

[RUMF-804] implement a minimal version of the recorder #670

Conversation

BenoitZugmeyer commented Dec 31, 2020 • edited Loading

Motivation

Changes

Testing

codecov-io commented Dec 31, 2020 • edited Loading

Codecov Report

sarina-dd left a comment

Choose a reason for hiding this comment

bcaudan left a comment

Choose a reason for hiding this comment

BenoitZugmeyer commented Dec 31, 2020 •

edited

Loading

codecov-io commented Dec 31, 2020 •

edited

Loading