[RUMF-803] import RRWeb #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
benoit/import-rrweb
branch
from
dd70776 to
90a1069
Compare
BenoitZugmeyer
changed the base branch from
master
to
benoit/add-rum-recorder-package
BenoitZugmeyer
commented
Dec 16, 2020
| } | ||
| }) | ||
|
|
||
| it('will only have one full snapshot without checkout config', () => { |
There was a problem hiding this comment.
As I said, I only included a single test, so we can discuss if we are comfortable with the current RRWeb integration before importing more tests.
This test corresponds to https://github.com/rrweb-io/rrweb/blob/master/test/record.test.ts#L74
bcaudan
approved these changes
Dec 17, 2020
BenoitZugmeyer
force-pushed
the
benoit/add-rum-recorder-package
branch
from
7e7969f to
e6ec684
Compare
BenoitZugmeyer
force-pushed
the
benoit/import-rrweb
branch
from
90a1069 to
63a0b14
Compare
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
==========================================
- Coverage 87.51% 77.72% -9.80%
==========================================
Files 55 60 +5
Lines 2531 3268 +737
Branches 524 710 +186
==========================================
+ Hits 2215 2540 +325
- Misses 316 728 +412
Continue to review full report at Codecov.
|
BenoitZugmeyer
force-pushed
the
benoit/import-rrweb
branch
from
63a0b14 to
88dc616
Compare
This was referenced Dec 31, 2020
BenoitZugmeyer
force-pushed
the
benoit/import-rrweb
branch
from
88dc616 to
4ac2a09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #657
Next PR: #670
Motivation
Import RRWeb in the rum-recorder codebase
Changes
Testing
I have gone over the contributing documentation.