SDK: better support for SPA routing #467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Given
startViewCollection
When
on window.location.hash changes
Then
check if the views are different.
If the hash fragment has changed and that it is not an Anchor nav, then the views are different.
Changes
PART 1
trackHash
functionareDifferentViews
to handle hash changesPART 2
noAnchorNavHashChange
check in thetrackHash
function that check if there is an equivalent id on one of the HTML elementsTesting
PART 1
✅ hash changes tests have been added both for pushStates and window.location.hash window.location.hash
Test with the Vue router without
mode: 'history'
:const router = new VueRouter({ routes })
PART 2
✅ test added that check if the hashchange is related to an Anchor nav