SDK: better support for SPA routing - STEP 2/2 : filter out html anchor tags changes #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## maxime.quentin/betterSupportForSPArouting #466 +/- ##
=============================================================================
+ Coverage 87.35% 87.67% +0.32%
=============================================================================
Files 32 32
Lines 2024 2028 +4
Branches 410 410
=============================================================================
+ Hits 1768 1778 +10
+ Misses 256 250 -6
Continue to review full report at Codecov.
|
mquentin
changed the base branch from
master
to
maxime.quentin/betterSupportForSPArouting
mquentin
changed the title
mquentin
changed the base branch from
maxime.quentin/betterSupportForSPArouting
to
maxime.quentin/betterSupportForSPAroutingAddhashTracking
bcaudan
reviewed
Jul 28, 2020
bcaudan
reviewed
Jul 28, 2020
bcaudan
reviewed
Jul 28, 2020
bcaudan
reviewed
Jul 28, 2020
bcaudan
reviewed
Jul 28, 2020
…g' into maxime.quentin/betterSupportForSPAroutingFilterOutAnchorNav
Base automatically changed from
maxime.quentin/betterSupportForSPAroutingAddhashTracking
to
maxime.quentin/betterSupportForSPArouting
July 28, 2020 12:38
|
|
…quentin/betterSupportForSPAroutingFilterOutAnchorNav
bcaudan
reviewed
Jul 30, 2020
bcaudan
reviewed
Jul 30, 2020
bcaudan
reviewed
Jul 30, 2020
packages/rum/src/viewCollection.ts
Outdated
Comment on lines
51
to
53
| // Anchor navigations would modify the location without generating a new view. | ||
| // These changes need to be acknowledged so they don't interfer with the next change areDifferentViews call | ||
| currentLocation = { ...location } |
There was a problem hiding this comment.
What about enforcing that by a unit test?
bcaudan
reviewed
Jul 30, 2020
bcaudan
reviewed
Jul 30, 2020
|
|
||
| it('should acknowledge the view location hash change after an Anchor navigation', (done) => { | ||
| const { lifeCycle } = setupBuilder.build() | ||
| const spyObj = mockGetElementById() |
There was a problem hiding this comment.
what about something more expressive than spyObj?
There was a problem hiding this comment.
as we just "clear" it, I did not look for a better name. Also the comment helps understanding the usage of spyObj.and.callThrough()
There was a problem hiding this comment.
it could have been an opportunity to be more expressive
bcaudan
approved these changes
Jul 30, 2020
bcaudan
added a commit
that referenced
this pull request
Aug 4, 2020
* SDK: better support for SPA routing - STEP 1/2 : add hash tracking (#463) * add hash tracking * ✅ add hash change tests * introduce renewViewOnChange * add better management and comments of the areViewDifferent hash part * set async tests for hashchanges * reset window.location.hash of previous tests * skip tesst using Promise for IE * replace jasmine promise with callback process * remove anchor check on this PR * ✅ and implem reviews * SDK: better support for SPA routing - STEP 2/2 : filter out html anchor tags changes (#466) * add hash tracking * ✅ add hash change tests * introduce renewViewOnChange * add better management and comments of the areViewDifferent hash part * set async tests for hashchanges * reset window.location.hash of previous tests * skip tesst using Promise for IE * replace jasmine promise with callback process * remove anchor check on this PR * add anchor nav filter * patch tslint error * ✅ and implem reviews * implement reviews regarding func naming and hash cleaning * simplify mockGetElementById * add e2e tests * simply anchor filter out proccess * implement reviews * unit test the hash change acknowledgement after an anchor nav * fix typo * fix typo v2 * fix mock hash Co-authored-by: Bastien Caudan <[email protected]>
bcaudan
deleted the
maxime.quentin/betterSupportForSPAroutingFilterOutAnchorNav
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Given
startViewCollection
When
on window.location.hash changes
Then
check if the views are different.
If the hash fragment has changed and that it is not an Anchor nav, then the views are different.
Changes
noAnchorNavHashChangecheck in thetrackHashfunction that check if there is an equivalent id on one of the HTML elementsTesting
✅ test added that check if the hashchange is related to an Anchor nav