Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-430] fix rollback #334

Merged
merged 2 commits into from
Apr 3, 2020
Merged

🐛 [RUMF-430] fix rollback #334

merged 2 commits into from
Apr 3, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 3, 2020

update session cookie cache to avoid old value to be restored

bcaudan added 2 commits April 3, 2020 10:27
update session cookie cache to avoid old value to be restored
@bcaudan bcaudan requested a review from a team as a code owner April 3, 2020 08:30
@codecov-io
Copy link

Codecov Report

Merging #334 into master will decrease coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   85.80%   85.53%   -0.27%     
==========================================
  Files          26       26              
  Lines        1479     1466      -13     
  Branches      312      312              
==========================================
- Hits         1269     1254      -15     
- Misses        210      212       +2     
Impacted Files Coverage Δ
packages/core/src/utils.ts 96.36% <ø> (-0.07%) ⬇️
packages/core/src/cookieMigration.ts 100.00% <100.00%> (ø)
packages/core/src/sessionManagement.ts 100.00% <100.00%> (ø)
packages/logs/src/loggerSession.ts 95.45% <100.00%> (-4.55%) ⬇️
packages/rum/src/rumSession.ts 100.00% <100.00%> (ø)
packages/logs/src/logger.ts 94.36% <0.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b81a7...7db562b. Read the comment docs.

Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@bcaudan bcaudan merged commit 4c3ed3a into master Apr 3, 2020
@bcaudan bcaudan deleted the bcaudan/fix-rollback branch April 3, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants