Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨[RUMF-430] new session cookie format #332

Merged
merged 3 commits into from
Apr 2, 2020
Merged

✨[RUMF-430] new session cookie format #332

merged 3 commits into from
Apr 2, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 2, 2020

  • single cookie to store all session info
  • remove _dd_l and _dd_r cookies
  • migration to not break active sessions during the new format deployment

bcaudan added 3 commits April 2, 2020 17:37
@bcaudan
🔥 remove cookie migration
9357443
@bcaudan
✨[RUMF-430] new session cookie format
99663b7 
- single cookie to store all session info
- remove _dd_l and _dd_r cookies
@bcaudan
✨[RUMF-430] add old cookies migration
9b6cbe6 
ensure to not break active sessions during the new format deployment
@bcaudan bcaudan requested a review from a team as a code owner April 2, 2020 15:39
@codecov-io
Copy link

Codecov Report

Merging #332 into master will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   85.53%   85.80%   +0.26%     
==========================================
  Files          26       26              
  Lines        1466     1479      +13     
  Branches      312      312              
==========================================
+ Hits         1254     1269      +15     
+ Misses        212      210       -2
Impacted Files Coverage Δ
packages/core/src/oldCookiesMigration.ts 100.00% <100.00%> (ø)
packages/core/src/sessionManagement.ts 100.00% <100.00%> (ø)
packages/core/src/utils.ts 96.42% <100.00%> (+0.06%) ⬆️
packages/logs/src/loggerSession.ts 100.00% <100.00%> (+4.54%) ⬆️
packages/rum/src/rumSession.ts 100.00% <100.00%> (ø)
packages/logs/src/logger.ts 95.77% <0.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ff312...9b6cbe6. Read the comment docs.

@bcaudan bcaudan merged commit 35b81a7 into master Apr 2, 2020
@bcaudan bcaudan deleted the bcaudan/new-cookie-format branch April 2, 2020 15:53
bcaudan added a commit that referenced this pull request Apr 3, 2020
@bcaudan
Revert "✨[RUMF-430] new session cookie format (#332)"
be13cc8 
This reverts commit 35b81a7.
bcaudan added a commit that referenced this pull request Apr 3, 2020
@bcaudan
🐛 [RUMF-430] fix rollback (#334)
4c3ed3a 
* Revert "✨[RUMF-430] new session cookie format (#332)"

This reverts commit 35b81a7.

* 🐛 fix rollback

update session cookie cache to avoid old value to be restored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcaudan @codecov-io