🐛 Fix replay visual viewport resize support #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2891 +/- ##
==========================================
+ Coverage 93.75% 93.77% +0.01%
==========================================
Files 266 267 +1
Lines 7575 7577 +2
Branches 1685 1685
==========================================
+ Hits 7102 7105 +3
+ Misses 473 472 -1 ☔ View full report in Codecov by Sentry. |
amortemousque
force-pushed
the
aymeric/fix-replay-visual-viewport
branch
from
55176b3 to
9fb112d
Compare
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
amortemousque
commented
Jul 24, 2024
| expect(getEmittedRecords()[0].type).toBe(RecordType.Focus) | ||
| }) | ||
|
|
||
| it('adds a Focus record on when taking a full snapshot', () => { |
There was a problem hiding this comment.
Now covered here:
| expect(getEmittedRecords()[1].type).toBe(RecordType.Focus) | ||
| }) | ||
|
|
||
| it('set has_focus to true if the document has the focus', () => { |
There was a problem hiding this comment.
Already covered here:
| expect((getEmittedRecords()[1] as FocusRecord).data.has_focus).toBe(true) | ||
| }) | ||
|
|
||
| it("set has_focus to false if the document doesn't have the focus", () => { |
There was a problem hiding this comment.
Already covered here:
Comment on lines
-157
to
-182
| it('adds an initial Focus record when starting to record', () => { | ||
| startRecording() | ||
| expect(getEmittedRecords()[1]).toEqual({ | ||
| type: RecordType.Focus, | ||
| timestamp: jasmine.any(Number), | ||
| data: { | ||
| has_focus: true, | ||
| }, | ||
| }) | ||
| }) | ||
|
|
||
| it('adds a Focus record on focus', () => { | ||
| startRecording() | ||
| emitSpy.calls.reset() | ||
|
|
||
| window.dispatchEvent(createNewEvent('focus')) | ||
| expect(getEmittedRecords()[0].type).toBe(RecordType.Focus) | ||
| }) | ||
|
|
||
| it('adds a Focus record on blur', () => { | ||
| startRecording() | ||
| emitSpy.calls.reset() | ||
|
|
||
| window.dispatchEvent(createNewEvent('blur')) | ||
| expect(getEmittedRecords()[0].type).toBe(RecordType.Focus) | ||
| }) |
There was a problem hiding this comment.
Basically covered here:
BenoitZugmeyer
approved these changes
Jul 24, 2024
| @@ -422,6 +369,95 @@ describe('record', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| describe('should collect records', () => { | |||
thomas-lebeau
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A regression has been introduced in the PR: the replay visual viewport resize support has been removed.
Changes
Testing
I have gone over the contributing documentation.