♻️✅ Harmonize record observers

[amortemousque]

Motivation

While implementing webview support for Session Replay, I identified inconsistencies in the recorder observers, plus some missing tests.

Changes

• Harmonize record observers to always
  • return BrowserRecord in callbacks
  • return a stop function
• Add tests for focusObserver, mediaInteractionObserver, scrollObserver, visualViewportResizeObserver
• I moved the observers initialization up in record() and removed the initObservers() wrapper.

Testing

• Local
• Staging
• Unit
• End to end

---

I have gone over the contributing documentation.

[cit-pr-commenter]

Bundles Sizes Evolution

📦 Bundle Name	Base Size	Local Size	𝚫	𝚫%	Status
Rum	156.36 KiB	155.43 KiB	-951 B	-0.59%	✅
Logs	55.34 KiB	55.34 KiB	0 B	0.00%	✅
Rum Slim	101.93 KiB	101.93 KiB	0 B	0.00%	✅
Worker	25.21 KiB	25.21 KiB	0 B	0.00%	✅

[amortemousque]

/to-staging

[dd-devflow]

🚂 Branch Integration: starting soon, merge in < 10m

Commit 552019963a will soon be integrated into staging-12.

This build is going to start soon! (estimated merge in less than 10m)

Use /to-staging -c to cancel this operation!

[dd-devflow]

🚂 Branch Integration: This commit was successfully integrated

Commit 552019963a has been merged into staging-12 in merge commit 42b67d2819.

Check out the triggered pipeline on Gitlab 🦊

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 97.14286% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.33%. Comparing base (9bc31ce) to head (0206557).
Report is 5 commits behind head on main.

Files	Patch %	Lines
.../domain/record/observers/viewportResizeObserver.ts	84.61%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2659      +/-   ##
==========================================
+ Coverage   92.91%   93.33%   +0.42%     
==========================================
  Files         239      238       -1     
  Lines        6931     6904      -27     
  Branches     1517     1517              
==========================================
+ Hits         6440     6444       +4     
+ Misses        491      460      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bcaudan]

❓ question: ‏any reason to have recordIds under trackers but not elementsScrollPositions for example?

[amortemousque]

No it was already under "observers/" which I just renamed. Do you have an improvement in mind?

[bcaudan]

ok, since it is the only one not being named trackXXX, it stands out a bit.
Compared to the others, it does not track browser events or APIs but store an internal state.
Looking at elementsScrollPositions, it seems a bit similar.

So I am wondering if both should not be inside or outside trackers.

wdyt?

[amortemousque]

No strong opinion so let's put it outside to have do the minimal amount of change :)