♻️ Get rid of setupBuilder from simple unit tests - pt 1

packages/rum-core/src/domain/view/viewMetrics/trackFirstInput.spec.ts

@@ -1,43 +1,42 @@
 import { type Duration, type RelativeTime, resetExperimentalFeatures } from '@datadog/browser-core'
 import { setPageVisibility } from '@datadog/browser-core/test'
-import type { TestSetupBuilder } from '../../../../test'
-import { appendElement, appendText, createPerformanceEntry, setup } from '../../../../test'
-import { LifeCycleEventType } from '../../lifeCycle'
+import { appendElement, appendText, createPerformanceEntry } from '../../../../test'
+import { LifeCycle, LifeCycleEventType } from '../../lifeCycle'
 import type { RumConfiguration } from '../../configuration'
 import { RumPerformanceEntryType } from '../../../browser/performanceObservable'
 import type { FirstInput } from './trackFirstInput'
 import { trackFirstInput } from './trackFirstInput'
 import { trackFirstHidden } from './trackFirstHidden'
 
 describe('firstInputTimings', () => {
-  let setupBuilder: TestSetupBuilder
+  const lifeCycle = new LifeCycle()
   let fitCallback: jasmine.Spy<(firstInput: FirstInput) => void>
   let configuration: RumConfiguration
+  let cleanup: () => void
+
+  function startFirstInputTracking() {
+    const firstHidden = trackFirstHidden(configuration)
+    const firstInputTimings = trackFirstInput(lifeCycle, configuration, firstHidden, fitCallback)
+
+    cleanup = () => {
+      firstHidden.stop()
+      firstInputTimings.stop()
+    }
+  }
 
   beforeEach(() => {
     configuration = {} as RumConfiguration
     fitCallback = jasmine.createSpy()
 
-    setupBuilder = setup().beforeBuild(({ lifeCycle }) => {
-      const firstHidden = trackFirstHidden(configuration)
-      const firstInputTimings = trackFirstInput(lifeCycle, configuration, firstHidden, fitCallback)
-
-      return {
-        stop() {
-          firstHidden.stop()
-          firstInputTimings.stop()
-        },
-      }
-    })
+    startFirstInputTracking()
   })
 
   afterEach(() => {
+    cleanup()
     resetExperimentalFeatures()
   })
 
   it('should provide the first input timings', () => {
-    const { lifeCycle } = setupBuilder.build()
-
     lifeCycle.notify(LifeCycleEventType.PERFORMANCE_ENTRIES_COLLECTED, [
       createPerformanceEntry(RumPerformanceEntryType.FIRST_INPUT),
     ])
@@ -50,8 +49,6 @@ describe('firstInputTimings', () => {
   })
 
   it('should provide the first input target selector', () => {
-    const { lifeCycle } = setupBuilder.build()
-
     lifeCycle.notify(LifeCycleEventType.PERFORMANCE_ENTRIES_COLLECTED, [
       createPerformanceEntry(RumPerformanceEntryType.FIRST_INPUT, {
         target: appendElement('<button id="fid-target-element"></button>'),
@@ -66,8 +63,6 @@ describe('firstInputTimings', () => {
   })
 
   it("should not provide the first input target if it's not a DOM element", () => {
-    const { lifeCycle } = setupBuilder.build()
-
     lifeCycle.notify(LifeCycleEventType.PERFORMANCE_ENTRIES_COLLECTED, [
       createPerformanceEntry(RumPerformanceEntryType.FIRST_INPUT, {
         target: appendText('text'),
@@ -82,8 +77,11 @@ describe('firstInputTimings', () => {
   })
 
   it('should be discarded if the page is hidden', () => {
+    // stop the current tracking from beforeEach
+    cleanup()
+
     setPageVisibility('hidden')
-    const { lifeCycle } = setupBuilder.build()
+    startFirstInputTracking()
 
     lifeCycle.notify(LifeCycleEventType.PERFORMANCE_ENTRIES_COLLECTED, [
       createPerformanceEntry(RumPerformanceEntryType.FIRST_INPUT),
@@ -93,8 +91,6 @@ describe('firstInputTimings', () => {
   })
 
   it('should be adjusted to 0 if the computed value would be negative due to browser timings imprecisions', () => {
-    const { lifeCycle } = setupBuilder.build()
-
     lifeCycle.notify(LifeCycleEventType.PERFORMANCE_ENTRIES_COLLECTED, [
       createPerformanceEntry(RumPerformanceEntryType.FIRST_INPUT, {
         processingStart: 900 as RelativeTime,