Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Get rid of setupBuilder from simple unit tests - pt 1 #2858

Merged

Conversation

N-Boutaib
Copy link
Contributor

@N-Boutaib N-Boutaib commented Jul 10, 2024

Motivation

Code reliability

Changes

Remove setupBuilder and use simple and straight forward setup for tests

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.67%. Comparing base (33125c3) to head (cf8abf7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2858   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files         266      266           
  Lines        7586     7586           
  Branches     1688     1688           
=======================================
  Hits         7106     7106           
  Misses        480      480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cit-pr-commenter bot commented Jul 10, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 0 B 161.66 KiB 161.66 KiB N/A%
Logs 0 B 57.97 KiB 57.97 KiB N/A%
Rum Slim 0 B 110.18 KiB 110.18 KiB N/A%
Worker 0 B 25.21 KiB 25.21 KiB N/A%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext N/A 0.001 0.001
addaction N/A 0.030 0.030
adderror N/A 0.032 0.032
addtiming N/A 0.001 0.001
startview N/A 0.950 0.950
startstopsessionreplayrecording N/A 0.815 0.815
logmessage N/A 0.019 0.019
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext NaN KiB 20.55 KiB NaN KiB
addaction NaN KiB 71.40 KiB NaN KiB
adderror NaN KiB 86.96 KiB NaN KiB
addtiming NaN KiB 16.67 KiB NaN KiB
startview NaN KiB 352.31 KiB NaN KiB
startstopsessionreplayrecording NaN KiB 14.05 KiB NaN KiB
logmessage NaN KiB 72.61 KiB NaN KiB

🔗 RealWorld

@N-Boutaib N-Boutaib force-pushed the najib.boutaib/RUM-5100-remove-unsed-setup-builder-from-tests branch from fb47873 to 94a3645 Compare July 11, 2024 11:44
@N-Boutaib N-Boutaib changed the title Najib.boutaib/rum 5100 remove unsed setup builder from tests 🎨 Get rid of setupBuilder from simple unit tests - pt 1 Jul 11, 2024
@N-Boutaib N-Boutaib marked this pull request as ready for review July 11, 2024 12:57
@N-Boutaib N-Boutaib requested a review from a team as a code owner July 11, 2024 12:57
@N-Boutaib N-Boutaib changed the title 🎨 Get rid of setupBuilder from simple unit tests - pt 1 ♻️ Get rid of setupBuilder from simple unit tests - pt 1 Jul 17, 2024
@N-Boutaib N-Boutaib merged commit 1aea760 into main Jul 17, 2024
20 checks passed
@N-Boutaib N-Boutaib deleted the najib.boutaib/RUM-5100-remove-unsed-setup-builder-from-tests branch July 17, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants