-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Get rid of setupBuilder from simple unit tests - pt 1 #2858
Merged
N-Boutaib
merged 18 commits into
main
from
najib.boutaib/RUM-5100-remove-unsed-setup-builder-from-tests
Jul 17, 2024
Merged
♻️ Get rid of setupBuilder from simple unit tests - pt 1 #2858
N-Boutaib
merged 18 commits into
main
from
najib.boutaib/RUM-5100-remove-unsed-setup-builder-from-tests
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2858 +/- ##
=======================================
Coverage 93.67% 93.67%
=======================================
Files 266 266
Lines 7586 7586
Branches 1688 1688
=======================================
Hits 7106 7106
Misses 480 480 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
N-Boutaib
force-pushed
the
najib.boutaib/RUM-5100-remove-unsed-setup-builder-from-tests
branch
from
July 11, 2024 11:44
fb47873
to
94a3645
Compare
N-Boutaib
changed the title
Najib.boutaib/rum 5100 remove unsed setup builder from tests
🎨 Get rid of setupBuilder from simple unit tests - pt 1
Jul 11, 2024
packages/rum-core/src/domain/view/viewMetrics/trackFirstContentfulPaint.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/view/viewMetrics/trackNavigationTimings.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/view/viewMetrics/trackLargestContentfulPaint.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/view/viewMetrics/trackFirstInput.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/view/viewMetrics/trackInitialViewMetrics.spec.ts
Show resolved
Hide resolved
packages/rum-core/src/domain/view/viewMetrics/trackInteractionToNextPaint.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/view/viewMetrics/trackCumulativeLayoutShift.spec.ts
Outdated
Show resolved
Hide resolved
BenoitZugmeyer
approved these changes
Jul 15, 2024
packages/rum-core/src/domain/view/viewMetrics/trackFirstInput.spec.ts
Outdated
Show resolved
Hide resolved
amortemousque
approved these changes
Jul 17, 2024
N-Boutaib
changed the title
🎨 Get rid of setupBuilder from simple unit tests - pt 1
♻️ Get rid of setupBuilder from simple unit tests - pt 1
Jul 17, 2024
nulrich
approved these changes
Jul 17, 2024
N-Boutaib
deleted the
najib.boutaib/RUM-5100-remove-unsed-setup-builder-from-tests
branch
July 17, 2024 09:27
RomanGaignault
pushed a commit
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Code reliability
Changes
Remove
setupBuilder
and use simple and straight forward setup for testsTesting
I have gone over the contributing documentation.