🐛 [RUM-1666] Don't set negative action loading time

packages/rum-core/src/domain/action/actionCollection.spec.ts

@@ -1,5 +1,6 @@
 import type { Duration, RelativeTime, ServerDuration, TimeStamp } from '@datadog/browser-core'
 import { createNewEvent } from '@datadog/browser-core/test'
+import type { RawRumActionEvent } from '@datadog/browser-rum-core'
 import type { TestSetupBuilder } from '../../../test'
 import { setup } from '../../../test'
 import { RumEventType, ActionType } from '../../rawRumEvent.types'
@@ -117,4 +118,24 @@ describe('actionCollection', () => {
     })
     expect(rawRumEvents[0].domainContext).toEqual({})
   })
+  it('should not set the loading time field of the action', () => {
+    const { lifeCycle, rawRumEvents } = setupBuilder.build()
+    const event = createNewEvent('pointerup', { target: document.createElement('button') })
+    lifeCycle.notify(LifeCycleEventType.AUTO_ACTION_COMPLETED, {
+      counts: {
+        errorCount: 0,
+        longTaskCount: 0,
+        resourceCount: 0,
+      },
+      duration: -10 as Duration,
+      event,
+      events: [event],
+      frustrationTypes: [],
+      id: 'aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee',
+      name: 'foo',
+      startClocks: { relative: 0 as RelativeTime, timeStamp: 0 as TimeStamp },
+      type: ActionType.CLICK,
+    })
+    expect((rawRumEvents[0].rawRumEvent as RawRumActionEvent).action.loading_time).toBeUndefined()
+  })
 })

packages/rum-core/src/domain/action/actionCollection.ts

@@ -1,6 +1,7 @@
 import type { ClocksState, Context, Observable } from '@datadog/browser-core'
 import { noop, assign, combine, toServerDuration, generateUUID } from '@datadog/browser-core'
 
+import { discardNegativeDuration } from '../view/viewCollection'
 import type { RawRumActionEvent } from '../../rawRumEvent.types'
 import { ActionType, RumEventType } from '../../rawRumEvent.types'
 import type { LifeCycle, RawRumEventCollectedData } from '../lifeCycle'
@@ -62,7 +63,7 @@ function processAction(
     ? {
         action: {
           id: action.id,
-          loading_time: toServerDuration(action.duration),
+          loading_time: discardNegativeDuration(toServerDuration(action.duration)),
           frustration: {
             type: action.frustrationTypes,
           },

packages/rum-core/src/domain/view/viewCollection.ts

@@ -132,6 +132,6 @@ function processViewUpdate(
   }
 }
 
-function discardNegativeDuration(duration: ServerDuration | undefined): ServerDuration | undefined {
+export function discardNegativeDuration(duration: ServerDuration | undefined): ServerDuration | undefined {
   return isNumber(duration) && duration < 0 ? undefined : duration
 }