Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weā€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

šŸ› [RUM-1666] Don't set negative action loading time #2764

Merged
merged 3 commits into from
May 22, 2024

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented May 17, 2024

Motivation

We noticed that we have actions with negative actions negative loading time. This is probably due to the fact that Date.now() is not monotonic and sometimes goes ā€œback in timeā€

Changes

If that's the case, we could just not set the loading time of the action event.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@RomanGaignault RomanGaignault marked this pull request as ready for review May 17, 2024 08:55
@RomanGaignault RomanGaignault requested a review from a team as a code owner May 17, 2024 08:55
@RomanGaignault RomanGaignault changed the title šŸ› [RUM-2970] Don't set negative action loading time šŸ› [RUM-1666] Don't set negative action loading time May 21, 2024
Copy link

cit-pr-commenter bot commented May 21, 2024

Bundles Sizes Evolution

šŸ“¦ Bundle Name Base Size Local Size šš« šš«% Status
Rum 157.94 KiB 157.94 KiB 4 B 0.00% āœ…
Logs 56.42 KiB 56.42 KiB 0 B 0.00% āœ…
Rum Slim 104.43 KiB 104.43 KiB 4 B 0.00% āœ…
Worker 25.21 KiB 25.21 KiB 0 B 0.00% āœ…
šŸš€ CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) šš«
adderror 0.033 N/A N/A
addaction 0.016 N/A N/A
logmessage 0.005 0.005 0.001
startview 0.961 0.946 -0.016
startstopsessionreplayrecording 0.772 0.743 -0.028
addtiming 0.001 0.001 0.000
addglobalcontext 0.002 0.001 -0.000

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests āœ…

Project coverage is 93.31%. Comparing base (f221bc9) to head (d053b71).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2764   +/-   ##
=======================================
  Coverage   93.31%   93.31%           
=======================================
  Files         241      242    +1     
  Lines        7062     7062           
  Branches     1561     1561           
=======================================
  Hits         6590     6590           
  Misses        472      472           

ā˜” View full report in Codecov by Sentry.
šŸ“¢ Have feedback on the report? Share it here.

@RomanGaignault
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented May 21, 2024

šŸš‚ Branch Integration: starting soon, merge in < 0s

Commit 0eb757a7d1 will soon be integrated into staging-21.

This build is going to start soon! (estimated merge in less than 0s)

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request May 21, 2024
@dd-devflow
Copy link

dd-devflow bot commented May 21, 2024

šŸš‚ Branch Integration: This commit was successfully integrated

Commit 0eb757a7d1 has been merged into staging-21 in merge commit 2668533c61.

Check out the triggered pipeline on Gitlab šŸ¦Š

@RomanGaignault RomanGaignault merged commit 0bd8b3e into main May 22, 2024
20 checks passed
@RomanGaignault RomanGaignault deleted the roman/negative-action-loading-time branch May 22, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants