-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weāll occasionally send you account related emails.
Already on GitHub? Sign in to your account
š [RUM-1666] Don't set negative action loading time #2764
Conversation
Bundles Sizes Evolution
š CPU Performance
|
Codecov ReportAll modified and coverable lines are covered by tests ā
Additional details and impacted files@@ Coverage Diff @@
## main #2764 +/- ##
=======================================
Coverage 93.31% 93.31%
=======================================
Files 241 242 +1
Lines 7062 7062
Branches 1561 1561
=======================================
Hits 6590 6590
Misses 472 472 ā View full report in Codecov by Sentry. |
/to-staging |
š Branch Integration: starting soon, merge in < 0s Commit 0eb757a7d1 will soon be integrated into staging-21. This build is going to start soon! (estimated merge in less than 0s) Use |
ā¦o staging-21 Co-authored-by: roman.gaignault <[email protected]>
š Branch Integration: This commit was successfully integrated Commit 0eb757a7d1 has been merged into staging-21 in merge commit 2668533c61. Check out the triggered pipeline on Gitlab š¦ |
Motivation
We noticed that we have actions with negative actions negative loading time. This is probably due to the fact that Date.now() is not monotonic and sometimes goes āback in timeā
Changes
If that's the case, we could just not set the loading time of the action event.
Testing
I have gone over the contributing documentation.