Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗ [RUMF-1379] heatmap: experiment improved selector regarding unicity #1741

Merged

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Sep 16, 2022

Motivation

Improve CSS selector quality for heatmaps

Changes

Add new heatmap CSS selector experiments:

  • one stopping the recursion as soon as the selector matches a single element on the page
  • one using combined selectors (ex: div > span) to test for unicity to reduce the need of relying on :nth-of-type selectors.
  • and a third to test both approaches together.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #1741 (de8792e) into main (1bf03b1) will increase coverage by 0.00%.
The diff coverage is 96.96%.

@@           Coverage Diff           @@
##             main    #1741   +/-   ##
=======================================
  Coverage   90.71%   90.71%           
=======================================
  Files         130      130           
  Lines        5049     5060   +11     
  Branches     1140     1146    +6     
=======================================
+ Hits         4580     4590   +10     
- Misses        469      470    +1     
Impacted Files Coverage Δ
...EventsCollection/action/getSelectorsFromElement.ts 98.73% <96.96%> (-1.27%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/heatmap--experiment-improved-children-unicity branch from f17a703 to b347287 Compare October 17, 2022 16:39
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/heatmap--experiment-improved-children-unicity branch from b347287 to 6c91013 Compare October 17, 2022 16:43
@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review October 17, 2022 16:49
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner October 17, 2022 16:49
Typo was a leftover from local testing. The eslint no-unreachable rule
has been enabled to avoid such mistakes
Use the same input to illustrate the difference between the expected
selectors.
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/heatmap--experiment-improved-children-unicity branch from de8792e to 3441d27 Compare October 19, 2022 16:46
@BenoitZugmeyer BenoitZugmeyer merged commit bf051a2 into main Oct 21, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/heatmap--experiment-improved-children-unicity branch October 21, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants