-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗ [RUMF-1379] heatmap: experiment improved selector regarding unicity #1741
Merged
BenoitZugmeyer
merged 9 commits into
main
from
benoit/heatmap--experiment-improved-children-unicity
Oct 21, 2022
Merged
⚗ [RUMF-1379] heatmap: experiment improved selector regarding unicity #1741
BenoitZugmeyer
merged 9 commits into
main
from
benoit/heatmap--experiment-improved-children-unicity
Oct 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1741 +/- ##
=======================================
Coverage 90.71% 90.71%
=======================================
Files 130 130
Lines 5049 5060 +11
Branches 1140 1146 +6
=======================================
+ Hits 4580 4590 +10
- Misses 469 470 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BenoitZugmeyer
force-pushed
the
benoit/heatmap--experiment-improved-children-unicity
branch
from
October 17, 2022 16:39
f17a703
to
b347287
Compare
BenoitZugmeyer
force-pushed
the
benoit/heatmap--experiment-improved-children-unicity
branch
from
October 17, 2022 16:43
b347287
to
6c91013
Compare
bcaudan
reviewed
Oct 19, 2022
packages/rum-core/src/domain/rumEventsCollection/action/getSelectorsFromElement.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/action/getSelectorsFromElement.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/action/getSelectorsFromElement.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/action/getSelectorsFromElement.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/action/getSelectorsFromElement.spec.ts
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/action/getSelectorsFromElement.ts
Outdated
Show resolved
Hide resolved
Typo was a leftover from local testing. The eslint no-unreachable rule has been enabled to avoid such mistakes
Use the same input to illustrate the difference between the expected selectors.
BenoitZugmeyer
force-pushed
the
benoit/heatmap--experiment-improved-children-unicity
branch
from
October 19, 2022 16:46
de8792e
to
3441d27
Compare
bcaudan
approved these changes
Oct 20, 2022
…iment-improved-children-unicity
BenoitZugmeyer
deleted the
benoit/heatmap--experiment-improved-children-unicity
branch
October 21, 2022 12:08
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve CSS selector quality for heatmaps
Changes
Add new heatmap CSS selector experiments:
div > span
) to test for unicity to reduce the need of relying on:nth-of-type
selectors.Testing
I have gone over the contributing documentation.