✅ fix unit tests for IE

DataDog · Oct 17, 2022 · b347287 · b347287
1 parent 13d5248
commit b347287
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 8 deletions.
diff --git a/packages/rum-core/src/domain/rumEventsCollection/action/getSelectorsFromElement.spec.ts b/packages/rum-core/src/domain/rumEventsCollection/action/getSelectorsFromElement.spec.ts
@@ -1,7 +1,7 @@
 import { isIE } from '@datadog/browser-core'
 import type { IsolatedDom } from '../../../../test/createIsolatedDom'
 import { createIsolatedDom } from '../../../../test/createIsolatedDom'
-import { getSelectorsFromElement } from './getSelectorsFromElement'
+import { getSelectorsFromElement, supportScopeSelector } from './getSelectorsFromElement'
 
 describe('getSelectorFromElement', () => {
   let isolatedDom: IsolatedDom
@@ -131,7 +131,14 @@ describe('getSelectorFromElement', () => {
               <button data-testid="foo"></button>
             </div>
           `)
-        ).toBe('BODY>BUTTON[data-testid="foo"]')
+        ).toBe(
+          supportScopeSelector()
+            ? 'BODY>BUTTON[data-testid="foo"]'
+            : // Degraded support for browsers not supporting scoped selector: the selector is still
+              // correct, but its quality is a bit worse, as using a stable attribute reduce the
+              // chances of matching a completely unrelated element.
+              'BODY>BUTTON'
+        )
       })
     })
   })
@@ -158,15 +165,20 @@ describe('getSelectorFromElement', () => {
     })
 
     it('only consider direct descendants (>) of the parent element', () => {
-      if (isIE()) {
-        pending('IE does not support :scope selectors')
-      }
       expect(
         getCombinedSelector(`
           <div><div><button></button></div></div>
           <div><button target></button></div>
         `)
-      ).toBe('BODY>DIV>BUTTON')
+      ).toBe(
+        supportScopeSelector()
+          ? 'BODY>DIV>BUTTON'
+          : // Degraded support for browsers not supporting scoped selector: the selector is still
+            // correct, but its quality is a bit worse as using a `nth-of-type` selector is a bit
+            // too specific and might not match if an element is conditionally inserted before the
+            // target.
+            'BODY>DIV:nth-of-type(2)>BUTTON'
+      )
     })
   })
 
@@ -192,7 +204,15 @@ describe('getSelectorFromElement', () => {
           <div><div><button></button></div></div>
           <div><button target></button></div>
         `)
-      ).toBe('BODY>DIV>BUTTON')
+      ).toBe(
+        supportScopeSelector()
+          ? 'BODY>DIV>BUTTON'
+          : // Degraded support for browsers not supporting scoped selector: the selector is still
+            // correct, but its quality is a bit worse as using a `nth-of-type` selector is a bit
+            // too specific and might not match if an element is conditionally inserted before the
+            // target.
+            'BODY>DIV:nth-of-type(2)>BUTTON'
+      )
     })
   })
 

diff --git a/packages/rum-core/src/domain/rumEventsCollection/action/getSelectorsFromElement.ts b/packages/rum-core/src/domain/rumEventsCollection/action/getSelectorsFromElement.ts
@@ -214,7 +214,8 @@ function combineSelector(parent: string, child: string | undefined): string {
 }
 
 let supportScopeSelectorCache: boolean | undefined
-function supportScopeSelector() {
+export function supportScopeSelector() {
+  return false
   if (supportScopeSelectorCache === undefined) {
     try {
       document.querySelector(':scope')