Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1122] fix view updates while session is expired #1228

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Dec 20, 2021

Motivation

Bump in session time spent matching the deployment of #1187.
Suspected root cause: regression allowing views to send updates while the session is expired

Changes

For view updates, check if the session is currently tracked instead of if the session was tracked at the beginning of the view.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan marked this pull request as ready for review December 20, 2021 12:51
@bcaudan bcaudan requested a review from a team as a code owner December 20, 2021 12:51
@bcaudan bcaudan changed the title 🐛 [RUMF-1122] fix view updated while session is expired 🐛 [RUMF-1122] fix view updates while session is expired Dec 20, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1228 (4d1b784) into main (433202e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1228      +/-   ##
==========================================
- Coverage   89.01%   88.99%   -0.03%     
==========================================
  Files         101      101              
  Lines        4324     4324              
  Branches      988      989       +1     
==========================================
- Hits         3849     3848       -1     
- Misses        475      476       +1     
Impacted Files Coverage Δ
packages/rum-core/src/domain/assembly.ts 100.00% <100.00%> (ø)
packages/core/src/tools/timeUtils.ts 97.14% <0.00%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 433202e...4d1b784. Read the comment docs.

@bcaudan bcaudan merged commit a2c5674 into main Dec 21, 2021
@bcaudan bcaudan deleted the bcaudan/fix-session-time-spent branch December 21, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants