🐛 [RUMF-1122] fix view updates while session is expired (#1228)

* 🐛 [RUMF-1122] fix view updated while session is expired * 👌 add explanation + todo
DataDog · Dec 21, 2021 · a2c5674 · a2c5674
1 parent 433202e
commit a2c5674
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/packages/rum-core/src/domain/assembly.spec.ts b/packages/rum-core/src/domain/assembly.spec.ts
@@ -492,6 +492,19 @@ describe('rum assembly', () => {
 
       expect(rumSessionManager.findTrackedSession).toHaveBeenCalledWith(123 as RelativeTime)
     })
+
+    it('should get current session state for view event', () => {
+      const rumSessionManager = createRumSessionManagerMock()
+      spyOn(rumSessionManager, 'findTrackedSession').and.callThrough()
+
+      const { lifeCycle } = setupBuilder.withSessionManager(rumSessionManager).build()
+      notifyRawRumEvent(lifeCycle, {
+        rawRumEvent: createRawRumEvent(RumEventType.VIEW),
+        startTime: 123 as RelativeTime,
+      })
+
+      expect(rumSessionManager.findTrackedSession).toHaveBeenCalledWith(undefined)
+    })
   })
 
   describe('session context', () => {

diff --git a/packages/rum-core/src/domain/assembly.ts b/packages/rum-core/src/domain/assembly.ts
@@ -81,7 +81,10 @@ export function startRumAssembly(
     ({ startTime, rawRumEvent, domainContext, savedCommonContext, customerContext }) => {
       const viewContext = parentContexts.findView(startTime)
       const urlContext = urlContexts.findUrl(startTime)
-      const session = sessionManager.findTrackedSession(startTime)
+      // allow to send events if the session was tracked when they start
+      // except for views which are continuously updated
+      // TODO: stop sending view updates when session is expired
+      const session = sessionManager.findTrackedSession(rawRumEvent.type !== RumEventType.VIEW ? startTime : undefined)
       if (session && viewContext && urlContext) {
         const actionContext = parentContexts.findAction(startTime)
         const commonContext = savedCommonContext || getCommonContext()