🐛 Do not trace requests when the session is not tracked #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
approved these changes
Oct 12, 2021
Codecov Report
@@ Coverage Diff @@
## main #1131 +/- ##
=======================================
Coverage 89.05% 89.05%
=======================================
Files 93 93
Lines 4195 4195
Branches 959 959
=======================================
Hits 3736 3736
Misses 459 459
Continue to review full report at Codecov.
|
bcaudan
approved these changes
Oct 14, 2021
amortemousque
deleted the
aymeric/not-trace-request-when-session-is-not-tracked
branch
BenoitZugmeyer
added a commit
that referenced
this pull request
Oct 14, 2021
pm_trace_id: 5744936 feature_branch_pipeline_id: 5744936 source: to-staging * commit 'a157deb7e346457895eb52abfa4336a7610b1e2a': 🐛 Do not trace requests when the session is not tracked (#1131)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Trace id / span id are added to every requests when the session is not tracked.
Some traces are missing the root browser span which prevent to compute metrics associated to the trace
To mitigate this issue we won't trace requests when the session is not tracked.
Changes
Update tracer to avoid tracing when the session is not tracked
Testing
Unit
I have gone over the contributing documentation.