Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 [RUMF-1041] add lcp info on view events #1129

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

This is an iteration over #1108 . With this change, we'll be able to accurately filter view events without LCP based on their discard reason and support

Changes

Testing

CI, manual


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner October 12, 2021 09:51
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/add-debug-info-on-views branch from f15a10f to 5c3d77e Compare October 12, 2021 09:54
@codecov-commenter
Copy link

Codecov Report

Merging #1129 (c526a1f) into main (c6cffa6) will increase coverage by 0.10%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
+ Coverage   89.03%   89.14%   +0.10%     
==========================================
  Files          93       93              
  Lines        4230     4236       +6     
  Branches      972      975       +3     
==========================================
+ Hits         3766     3776      +10     
+ Misses        464      460       -4     
Impacted Files Coverage Δ
packages/rum-core/src/rawRumEvent.types.ts 100.00% <ø> (ø)
.../domain/rumEventsCollection/view/viewCollection.ts 93.75% <66.66%> (-6.25%) ⬇️
...umEventsCollection/view/trackInitialViewTimings.ts 95.94% <81.81%> (+7.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6cffa6...c526a1f. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit 3cdb491 into main Oct 14, 2021
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/add-debug-info-on-views branch October 14, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants