SSV-22900: Return the usable spa dspace in the performance metrics ioctl #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tinker with slop space accounting with dedup Do not include the deduplicated space usage in the slop space reservation, it leads to surprising outcomes. * Update spa_dedup_dspace sometimes Sometimes, we get into spa_get_slop_space() with spa_dedup_dspace=~0ULL, AKA "unset", while spa_dspace is correctly set. So call the code to update it before we use it if we hit that case. Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: Mark Maybee <[email protected]> Signed-off-by: Rich Ercolani <[email protected]> Closes openzfs#12271
datacore-ramya
approved these changes
Oct 12, 2023
arun-kv
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: SSV-22900: CO available space in Disk pool is showing wrong value.
Issue: In the case of raidz1, the DMC was showing the total size of all the raidz1 disks and special mirror vdev and not the actual usable capacity.
Fix: Get the dspace(deflated space) from the spa normal metaslab class and subtract the slop reservation space to get the actual usable pool size.
The commit 7d275c6 (Tinker with slop space accounting with dedup) is a prerequisite commit that was down streamed. Without this commit, more slop space was reserved when deduplication data was present and it was showing lesser available space.
Tests by Dev: -
http://10.200.2.48:8080/job/OpenZFS-Test-Suite/115/console
Tests to be done by QA: _