Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSV-22933: Do not include special mirror vdev size in ZPOOL_GET_SIZE_STATS ioctl response. #90

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

datacore-rm
Copy link

Jira: SSV-22933 : zpool allocations exceed 85% when CO is configured with special mirror vdev

Issue: Special mirror vdev size/alloc is included in the zpool size reported to the pool driver in the ZPOOL_GET_SIZE_STATS ioctl response. This results in pool driver exceeding the 85% zpool allocation thresh hold.

Fix: Since special vdev is used only to store metadata, it's size should not be included.

Tests by Dev: -
Tested on both RAID0 and RAID5 with/without special mirror vdev to validate that correct zpool sizes and alloc details are reported in the ioctl response. Zpool allocations did not exceed thresh hold of ~85%.

Tests to be done by QA:

  1. Add the new low space test cases with special mirror vdev in the ILDC DCAF test suite.
  2. Manual testing.

@datacore-ramya
Copy link

metaslab_class_get_alloc and metaslab_class_get_space considers parity disk space as well which will be different from change #89. This info will be documented for internal reference.

@datacore-rm datacore-rm merged commit 1436207 into rel-10psp17 Oct 16, 2023
0 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants