This repository has been archived by the owner on Nov 28, 2024. It is now read-only.
Show number of rows processed #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After looking at the instance variables the CSVlint gem make available and which of same are preserved in this app current_line has been chosen as indicator of rows processed. line_limit_reached method may provide a way of robustly testing how well this exposure functions (in instances where CSV files halt streaming processing)
Current features do nothing more than check if string is set, more to do
For future use and to determine number of rows processed
this logic belongs elsewhere, but the current_line variable needs to account for headers and the variables current line being 1 row greater than total rows in CSV
Floppy
approved these changes
May 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #261, suggestions listed in #261 (comment) advised for subsequent fixes