Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

Show number of rows processed on Validation Results page #261

Closed
Stephen-Gates opened this issue Mar 9, 2016 · 1 comment · Fixed by #286
Closed

Show number of rows processed on Validation Results page #261

Stephen-Gates opened this issue Mar 9, 2016 · 1 comment · Fixed by #286
Assignees

Comments

@Stephen-Gates
Copy link

Provide confidence that the whole file was processed especially when you use the "Validate Again" button and the CSV behind the URL may have changed in size.

Important to know if processing completed or a large file size resulted in only part of the file being processed. Especially given the warning on the /About page
validateagain

goodtables

@quadrophobiac
Copy link
Contributor

quadrophobiac commented Apr 19, 2017

this is a small fix that is currently stalled due to below. progress so far at https://github.com/theodi/csvlint/compare/show-number-of-rows-processed

  • resolve CSVlint .env to run locally without problems noted in File uploads hang on dev instance of CSVlint #281
  • decide on utilising csvlint gem method line_limit_reached as a way of testing this addition
    with planned testing additions of
  • write tests for stress test fixtures (multiples of 1000 rows and 1MB and 10MB file size)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants