WIP: Update dependencies #3253
Closed
WIP: Update dependencies #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR covers #3155 |
nicosang
reviewed
May 13, 2020
| "localforage": "^1.7.1", | ||
| "request": "^2.87.0", | ||
| "request-promise": "^4.2.2" | ||
| "imsc": "^1.0.2", |
There was a problem hiding this comment.
update to version 1.1.1 of imsc could be a good idea... ;-)
There was a problem hiding this comment.
thanks, will put this on the todo list, too
There was a problem hiding this comment.
aj, ver 1.1.1 has obviously breaking changes to our unit tests. anyway, i accept the challenge ;)
There was a problem hiding this comment.
If imsc lib is updated, functional/manual tests for streams with subtitles must be carried out thoroughly
mlasak
force-pushed
the
update-dependencies
branch
from
8a7a38a to
af5f340
Compare
Breaking changes are not included
iron-mocha is a archived, inactive project introducing two critical vulnerabilities. Moreover, using 'npm run debug' it assumes that iron-mocha is installed globally and this command does not work the way it was intended. Finally, there is another more recent command 'npm run debug-mocha' which does the same.
istanbul package is deprecated and nyc is the successor tool Test coverage check is still possible with 'npm run coverage'
mocha is updated to a more recent version without breaking tests. Gruntfile is updated to use newer coverage tool nyc and more recent mocha
The hook is installed using a node script
* Removed grunt-contrib-jshint module * generated rules from existing .jshintrc * removed .jshintrc * added globals * fixed all issues that break linting/code style rules
Ignores to code style and linting rules should be rare exception
mlasak
force-pushed
the
update-dependencies
branch
from
d415be8 to
3b9f283
Compare
This was referenced Apr 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation to #2880 we started to cleanup and update the dependencies (prod and dev).
Feedback very welcome!
What has been done so far and what we're still doing:
- [ ] update intern dev dep-> Update intern dev dependency #3370- [ ] update imsc prod dep-> Update imscJS prod dependency #3371What has to be done before merging