Replace jshint and its rules by eslint equivalents

* Removed grunt-contrib-jshint module
* generated rules from existing .jshintrc
* removed .jshintrc
* added globals
* fixed all issues that break linting/code style rules

.eslintrc.json

@@ -3,6 +3,35 @@
     "sourceType": "module",
     "ecmaVersion": 2015
   },
+  "env": {
+    "browser": true,
+    "jquery": true,
+    "node": true,
+    "es6": true
+  },
+  "globals": {
+    "it": "readonly",
+    "describe": "readonly",
+    "beforeEach": "readonly",
+    "before": "readonly",
+    "afterEach": "readonly",
+    "after": "readonly",
+    "kendo": "readonly",
+    "utils": "readonly",
+    "MediaPlayer": "readonly",
+    "Dash": "readonly",
+    "WebKitMediaSource": "readonly",
+    "MediaSource": "readonly",
+    "WebKitMediaKeys": "readonly",
+    "MSMediaKeys": "readonly",
+    "MediaKeys": "readonly",
+    "Caster": "readonly",
+    "TextTrackCue": "readonly",
+    "HTMLMediaElement": "readonly",
+    "MediaError": "readonly",
+    "cea608parser": "readonly",
+    "dashjs": "readonly"
+  },
   "rules": {
     "indent": [
       2,
@@ -53,6 +82,17 @@
       {
         "allowEmptyCatch": true
       }
-    ]
+    ],
+    "no-caller": 2,
+    "no-use-before-define": [
+      2,
+      {
+        "functions": false
+      }
+    ],
+    "no-undef": 2,
+    "no-unused-vars": 2,
+    "strict": 0,
+    "no-loop-func": 2
   }
 }

Gruntfile.js

@@ -15,15 +15,6 @@ module.exports = function (grunt) {
             build: ['build/temp'],
             dist: ['dist/*']
         },
-        jshint: {
-            src: {
-                src: ['src/**/*.js', 'test/unit/mocks/*.js', 'test/unit/*.js', 'Gruntfile.js'],
-                options: {
-                    jshintrc: '.jshintrc'
-                }
-            }
-        },
-
         uglify: {
             options: {
                 banner: '/*! v<%= pkg.version %>-<%= githash.dist.short %>, <%= grunt.template.today("isoUtcDateTime") %> */',
@@ -433,14 +424,14 @@ module.exports = function (grunt) {
     require('load-grunt-tasks')(grunt);
     grunt.loadNpmTasks('grunt-string-replace');
     grunt.registerTask('default', ['dist', 'test']);
-    grunt.registerTask('dist', ['clean', 'jshint', 'eslint', 'browserify:mediaplayer', 'browserify:protection', 'browserify:reporting', 'browserify:mss', 'browserify:offline', 'browserify:all', 'babel:es5', 'minimize', 'copy:dist']);
+    grunt.registerTask('dist', ['clean', 'eslint', 'browserify:mediaplayer', 'browserify:protection', 'browserify:reporting', 'browserify:mss', 'browserify:offline', 'browserify:all', 'babel:es5', 'minimize', 'copy:dist']);
     grunt.registerTask('minimize', ['exorcise', 'githash', 'uglify']);
     grunt.registerTask('test', ['nyc:test']);
     grunt.registerTask('watch', ['browserify:watch']);
     grunt.registerTask('watch-dev', ['browserify:watch_dev']);
     grunt.registerTask('release', ['default', 'jsdoc']);
     grunt.registerTask('debug', ['clean', 'browserify:all', 'exorcise:all', 'copy:dist']);
-    grunt.registerTask('lint', ['jshint', 'eslint']);
+    grunt.registerTask('lint', ['eslint']);
     grunt.registerTask('dev', ['browserSync', 'watch-dev']);
     grunt.registerTask('deploy', ['string-replace', 'ftp_push']);
 };

package.json

@@ -33,7 +33,6 @@
     "grunt-contrib-clean": "^2.0.0",
     "grunt-contrib-connect": "^2.0.0",
     "grunt-contrib-copy": "^1.0.0",
-    "grunt-contrib-jshint": "^0.11.2",
     "grunt-contrib-uglify": "^4.0.1",
     "grunt-contrib-watch": "^1.1.0",
     "grunt-eslint": "^22.0.0",

src/mss/parser/MssParser.js

@@ -114,7 +114,6 @@ function MssParser(config) {
         let segmentTemplate,
             qualityLevels,
             representation,
-            segments,
             i;
 
         const name = streamIndex.getAttribute('Name');
@@ -184,8 +183,6 @@ function MssParser(config) {
         // Set SegmentTemplate
         adaptationSet.SegmentTemplate = segmentTemplate;
 
-        segments = segmentTemplate.SegmentTimeline.S_asArray;
-
         return adaptationSet;
     }
 
@@ -460,8 +457,8 @@ function MssParser(config) {
     }
 
     function getWRMHeaderFromPRHeader(prHeader) {
-        let length,
-            recordCount,
+        let // length,
+            // recordCount,
             recordType,
             recordLength,
             recordValue;
@@ -470,11 +467,11 @@ function MssParser(config) {
         // Parse PlayReady header
 
         // Length - 32 bits (LE format)
-        length = (prHeader[i + 3] << 24) + (prHeader[i + 2] << 16) + (prHeader[i + 1] << 8) + prHeader[i];
+        // length = (prHeader[i + 3] << 24) + (prHeader[i + 2] << 16) + (prHeader[i + 1] << 8) + prHeader[i];
         i += 4;
 
         // Record count - 16 bits (LE format)
-        recordCount = (prHeader[i + 1] << 8) + prHeader[i];
+        // recordCount = (prHeader[i + 1] << 8) + prHeader[i];
         i += 2;
 
         // Parse records