Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Start for Users on README.md is not working. #1722

Closed
yoonsy opened this issue Dec 23, 2016 · 2 comments
Closed

Quick Start for Users on README.md is not working. #1722

yoonsy opened this issue Dec 23, 2016 · 2 comments
Labels
Bug Regression
Milestone
v2.4.1

Comments

@yoonsy
Copy link

yoonsy commented Dec 23, 2016 •
edited
Loading

The sample code on Quick Start for Users on README.md is not working.

<script src="http://cdn.dashjs.org/latest/dash.all.min.js"></script>
...
<style>
    video {
       width: 640px;
       height: 360px;
    }
</style>
...
<body>
   <div>
       <video data-dashjs-player autoplay src="http://dash.edgesuite.net/envivio/EnvivioDash3/manifest.mpd" controls></video>
   </div>
</body>

However, the standard setup is working well.
@davemevans
Copy link
Contributor

Caused by #1694

@davemevans davemevans mentioned this issue Dec 28, 2016
Closed
5 tasks
@davemevans davemevans mentioned this issue Jan 9, 2017
Closed
@JontyUsborne JontyUsborne mentioned this issue Jan 10, 2017
Merged
@LloydW93 LloydW93 added this to the v2.4.1 milestone Jan 11, 2017
@vinaynb
Copy link

vinaynb commented Jan 11, 2017 •
edited
Loading

Spent quite some time figuring out why suddenly the example code doesn't work. There's a pull request already which fixes this #1736. Hopefully it will be merged soon 😄

dsparacio pushed a commit that referenced this issue Jan 11, 2017
Merge pull request #1736 from bbc/createAll-AJAX
dbf9fc5 
Fix #1722: Wait for dashjs before creating element(s) if loaded asynchronously
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Regression
Projects
None yet
Milestone
v2.4.1
Development

No branches or pull requests
4 participants
@vinaynb @LloydW93 @yoonsy @davemevans