Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation keys #3192

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Conversation

Andrea-Guevara
Copy link
Contributor

References

Description

Translating keys into Spanish.

Instructions for Reviewers

Translating keys from the search filters and notifications menu section. It turned out that none of the keys in this commit had been translated into Spanish.

List of changes in this PR:

  • Adding Spanish translated keys in the “es.json5” file

To reproduce:

  • log in as administrator.
  • Change the language to Spanish.
  • See that the text translations for “Spanish” in the search filters are present.
  • Go to the notifications menu section and see that the text translations for “Spanish” are present.

@tdonohue tdonohue added bug i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jul 17, 2024
@IgorBaptist4 IgorBaptist4 force-pushed the SpanishTranslationKeys branch from 12a7d3c to 8c60a67 Compare September 4, 2024 20:27
Copy link

github-actions bot commented Nov 1, 2024

Hi @Andrea-Guevara,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@nwoodward
Copy link
Contributor

Thanks @Andrea-Guevara! These translations look great. I just have a few more to add from the advanced search. And while we are adding missing translations we should add the new lines from #2930.

They are here:

"dso-selector.placeholder.type.community": "community",
"dso-selector.placeholder.type.collection": "collection",
"dso-selector.placeholder.type.item": "item",

I think that would fix many of the remaining issues from #2913.

@Andrea-Guevara
Copy link
Contributor Author

Good morning @nwoodward! I've made the adjustments you requested. If you have any questions, please let me know!

@nwoodward
Copy link
Contributor

Good morning @Andrea-Guevara! Thanks for the additional translations. Now we just need the four advanced search translations mentioned above and this PR will be done.

@Andrea-Guevara
Copy link
Contributor Author

@nwoodward I don't quite understand if you're going to add new translation keys or if I am!

@nwoodward
Copy link
Contributor

Hi @Andrea-Guevara. I'm so sorry for being confusing. Can you add them to this pull request? I think that will be the fastest way.

@Andrea-Guevara
Copy link
Contributor Author

These?
Screenshot_40

@nwoodward
Copy link
Contributor

nwoodward commented Jan 3, 2025

No, these. They are still in English after I switch to Español.

"search.sidebar.advanced-search.filter-by": "Filter by",
"search.sidebar.advanced-search.filters": "Filters",
"search.sidebar.advanced-search.operators": "Operators",
"search.sidebar.advanced-search.add": "Add",

Screenshot 2025-01-03 at 2 38 54 PM

@Andrea-Guevara
Copy link
Contributor Author

Good morning @nwoodward! done

Copy link
Contributor

@nwoodward nwoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Andrea-Guevara! Everything looks good.

@tdonohue tdonohue added this to the 9.0 milestone Jan 6, 2025
@tdonohue tdonohue merged commit 2c22517 into DSpace:main Jan 6, 2025
15 checks passed
@dspace-bot
Copy link
Contributor

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3192-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3192-to-dspace-8_x
git switch --create backport-3192-to-dspace-8_x
git cherry-pick -x 65ce727157264ad608f63a3f6b1bb0ff723202e2 d252108f85b2dfeda6e036d062eb972c3cdd99e5 8c60a67e8ed08a32153891a209ba95808b3e752d 01cb2c7429a99c8e8fba23fbd17a1436a71f0ed7 fda933022101311a12308b50209719eec7520cd2

@tdonohue tdonohue removed the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug i18n / l10n Internationalisation and localisation, related to message catalogs
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Missing translations to Spanish
4 participants