-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanish translation keys #3192
Spanish translation keys #3192
Conversation
12a7d3c
to
8c60a67
Compare
Hi @Andrea-Guevara, |
Thanks @Andrea-Guevara! These translations look great. I just have a few more to add from the advanced search. And while we are adding missing translations we should add the new lines from #2930. They are here: dspace-angular/src/assets/i18n/en.json5 Lines 1731 to 1735 in 6ac9229
I think that would fix many of the remaining issues from #2913. |
Good morning @nwoodward! I've made the adjustments you requested. If you have any questions, please let me know! |
Good morning @Andrea-Guevara! Thanks for the additional translations. Now we just need the four advanced search translations mentioned above and this PR will be done. |
@nwoodward I don't quite understand if you're going to add new translation keys or if I am! |
Hi @Andrea-Guevara. I'm so sorry for being confusing. Can you add them to this pull request? I think that will be the fastest way. |
Good morning @nwoodward! done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @Andrea-Guevara! Everything looks good.
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3192-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3192-to-dspace-8_x
git switch --create backport-3192-to-dspace-8_x
git cherry-pick -x 65ce727157264ad608f63a3f6b1bb0ff723202e2 d252108f85b2dfeda6e036d062eb972c3cdd99e5 8c60a67e8ed08a32153891a209ba95808b3e752d 01cb2c7429a99c8e8fba23fbd17a1436a71f0ed7 fda933022101311a12308b50209719eec7520cd2 |
References
Description
Translating keys into Spanish.
Instructions for Reviewers
Translating keys from the search filters and notifications menu section. It turned out that none of the keys in this commit had been translated into Spanish.
List of changes in this PR:
To reproduce: