Fix sync-i18n script throwing a compile error & added some missing translation keys #2930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Currently the
sync-i18n
script can't be executed because of a type issue caused by the Typescript 4.4 update. Because this PR was ridiculously small I also fixed another issue at the same time. The second fix makes the DSO type in thedso-selector
translatable.Instructions for Reviewers
List of changes in this PR:
sync-i18n-files.ts
to verify that the variable returned by the catch block is of typeError
dso-selector
: Community, Collection & ItemGuidance for how to test/review this PR:
sync-i18n
script againcommunity
/collection
/item
in French/DutchChecklist
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.