Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Only keep analytics on production #2435

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Only keep analytics on production #2435

merged 1 commit into from
Nov 6, 2017

Conversation

msecret
Copy link
Contributor

@msecret msecret commented Nov 3, 2017

Fixes issue(s) #2434 .

CircleCI

😎 PREVIEW

/cc relevant people

@coreycaitlin
Copy link
Contributor

@msecret I don't feel super qualified to review this one — what do you think about tagging @laurenancona or @toolness for review?

Copy link
Contributor

@toolness toolness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to mee, so long as the development/staging branches and the default configuration don't have analytics IDs defined!

@msecret
Copy link
Contributor Author

msecret commented Nov 6, 2017

Yea the IDs are defined in Federalist for just the production branch

@msecret msecret merged commit 7cb873d into dev Nov 6, 2017
@msecret msecret deleted the ms-fix_analytics branch November 6, 2017 18:46
@msecret msecret mentioned this pull request Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants