This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
Staging --> master v2.1.6 #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update webpack
How it works production update
Add new search index
Fixes How it works ribbon
dev --> staging
houndci-bot
reviewed
Feb 9, 2017
| : contentTypes['default'] | ||
| // Initalize lunr with the fields it will be searching on. I've given title | ||
| // a boost of 10 to indicate matches on this field are more important. | ||
| var idx = lunr(function () { |
houndci-bot
reviewed
Feb 9, 2017
| : contentTypes['default'] | ||
| // Initalize lunr with the fields it will be searching on. I've given title | ||
| // a boost of 10 to indicate matches on this field are more important. | ||
| var idx = lunr(function () { |
houndci-bot
reviewed
Feb 9, 2017
| this.field('internal', { boost: 100 }); | ||
| }); | ||
|
|
||
| for (var key in window.store) { |
There was a problem hiding this comment.
The body of a for in should be wrapped in an if statement to filter unwanted properties from the prototype.
houndci-bot
reviewed
Feb 9, 2017
| this.field('internal', { boost: 100 }); | ||
| }); | ||
|
|
||
| for (var key in window.store) { |
There was a problem hiding this comment.
The body of a for in should be wrapped in an if statement to filter unwanted properties from the prototype.
houndci-bot
reviewed
Feb 9, 2017
| var item = store[results[i].ref]; | ||
|
|
||
| var tags = (item.tag || []) | ||
| .map(function(tag) { |
There was a problem hiding this comment.
Don't make functions within a loop.
houndci-bot
reviewed
Feb 9, 2017
| var item = store[results[i].ref]; | ||
|
|
||
| var tags = (item.tag || []) | ||
| .map(function(tag) { |
There was a problem hiding this comment.
Don't make functions within a loop.
houndci-bot
reviewed
Feb 9, 2017
| ); | ||
| (function() { | ||
| function displaySearchResults(results, store) { | ||
| var $searchResults = $('.search-results-container .search-results-container'); |
houndci-bot
reviewed
Feb 9, 2017
| ); | ||
| (function() { | ||
| function displaySearchResults(results, store) { | ||
| var $searchResults = $('.search-results-container .search-results-container'); |
houndci-bot
reviewed
Feb 9, 2017
| obj = {} | ||
| collections.each do |collection| | ||
| collection['docs'].each do |doc| | ||
| if doc.data['title'] && doc.data['description'] && doc.data['tag'] && doc.data['permalink'] |
houndci-bot
reviewed
Feb 9, 2017
| str.downcase.strip.gsub(' ', '-').gsub(/[^\w-]/, '') | ||
| end | ||
|
|
||
| def create_store(collections) |
There was a problem hiding this comment.
Assignment Branch Condition size for create_store is too high. [25.5/15]
houndci-bot
reviewed
Feb 9, 2017
| obj = {} | ||
| collections.each do |collection| | ||
| collection['docs'].each do |doc| | ||
| if doc.data['title'] && doc.data['description'] && doc.data['tag'] && doc.data['permalink'] |
houndci-bot
reviewed
Feb 9, 2017
| end | ||
|
|
||
| def slugify(str) | ||
| str.downcase.strip.gsub(' ', '-').gsub(/[^\w-]/, '') |
houndci-bot
reviewed
Feb 9, 2017
| str.downcase.strip.gsub(' ', '-').gsub(/[^\w-]/, '') | ||
| end | ||
|
|
||
| def create_store(collections) |
There was a problem hiding this comment.
Assignment Branch Condition size for create_store is too high. [25.5/15]
houndci-bot
reviewed
Feb 9, 2017
| end | ||
|
|
||
| def slugify(str) | ||
| str.downcase.strip.gsub(' ', '-').gsub(/[^\w-]/, '') |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to v2.1.6
Changes from #2186, #2188, #2195, #2197, #2191
😎 PREVIEW
Changes proposed in this pull request:
data-expressiondependency update [email protected] #2188/cc @meiqimichelle @shawnbot @coreycaitlin @ericronne