This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
Fixes How it works ribbon #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 12, 2017
_sass/components/_ribbon.scss
Outdated
| flex-direction: row; | ||
| justify-content: space-around; | ||
|
|
||
| &> *:not(a) { |
houndci-bot
reviewed
Jan 12, 2017
_sass/components/_ribbon.scss
Outdated
| align-self: center; | ||
| } | ||
|
|
||
| @include respond-to(small-to-huge) { |
There was a problem hiding this comment.
Expected item on line 91 to appear before line 81. Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
houndci-bot
reviewed
Jan 12, 2017
_sass/components/_ribbon.scss
Outdated
|
|
||
| &> * { | ||
| align-self: center; | ||
| text-align: center; |
There was a problem hiding this comment.
Properties should be ordered align-self, margin-bottom, text-align
houndci-bot
reviewed
Jan 12, 2017
_sass/components/_ribbon.scss
Outdated
| display: flex; | ||
| flex-direction: column; | ||
|
|
||
| &> * { |
|
Thanks, @houndci-bot 🙄 |
|
Eeep, I missed this one! Is it ready to roll after @ericronne review? |
|
hm maybe after a quick live tweak during our next pairing? 😬 |
|
It built! And I made a new issue to hold the overflow! #2201 cc @ericronne |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue(s) #2150
😎 PREVIEW
Changes proposed in this pull request:
How it worksribbonAboutribbon/cc @ericronne