Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit start = 0 modifiers to parameters without default binding #187

Closed
wants to merge 1 commit into from
Closed

Added explicit start = 0 modifiers to parameters without default binding #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ThermofluidStream/FlowControl/BasicControlValve.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ model BasicControlValve "Basic valve model with optional flow characteristics fo

parameter FlowCoeffType flowCoefficient = FlowCoeffType.Kvs "Select type of flow coefficient" annotation(Dialog(group = "Valve parameters"));
//Reference Values
parameter Real Kvs(unit = "m3/h") "Kvs-value (metric) from data sheet (valve fully open)"
parameter Real Kvs(unit = "m3/h", start = 0) "Kvs-value (metric) from data sheet (valve fully open)"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.Kvs)));
parameter Real Cvs_US "Cvs-value (US [gal/min]) from data sheet (valve fully open)"
parameter Real Cvs_US(start = 0) "Cvs-value (US [gal/min]) from data sheet (valve fully open)"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.Cvs_US)));
parameter Real Cvs_UK "Cvs-value (UK [gal/min]) from data sheet (valve fully open)"
parameter Real Cvs_UK(start = 0) "Cvs-value (UK [gal/min]) from data sheet (valve fully open)"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.Cvs_UK)));
parameter SI.MassFlowRate m_flow_ref_set "Set reference mass flow in kg/s"
parameter SI.MassFlowRate m_flow_ref_set(start = 0) "Set reference mass flow in kg/s"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.m_flow_set)));

protected
Expand Down
10 changes: 5 additions & 5 deletions ThermofluidStream/FlowControl/SpecificValveType.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@ model SpecificValveType "Specific technical valve types"
parameter FlowCoeffType flowCoefficient = FlowCoeffType.Kvs "Select type of flow coefficient"
annotation(Dialog(group = "Valve parameters"));
//Set valve data as parameter
parameter Modelica.Units.SI.Diameter d_valve "Flow diameter"
parameter Modelica.Units.SI.Diameter d_valve(start = 0) "Flow diameter"
annotation (Evaluate=true, Dialog(group="Valve parameters", enable=(flowCoefficient== FlowCoeffType.flowDiameter)));
//Reference Values
parameter Real Kvs(unit = "m3/h") "Kvs-value (metric) from data sheet (valve fully open)"
parameter Real Kvs(unit = "m3/h", start = 0) "Kvs-value (metric) from data sheet (valve fully open)"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.Kvs)));
parameter Real Cvs_US "Cvs-value (US [gal/min]) from data sheet (valve fully open)"
parameter Real Cvs_US(start = 0) "Cvs-value (US [gal/min]) from data sheet (valve fully open)"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.Cvs_US)));
parameter Real Cvs_UK "Cvs-value (UK [gal/min]) from data sheet (valve fully open)"
parameter Real Cvs_UK(start = 0) "Cvs-value (UK [gal/min]) from data sheet (valve fully open)"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.Cvs_UK)));
parameter SI.MassFlowRate m_flow_ref_set "Reference mass flow rate"
parameter SI.MassFlowRate m_flow_ref_set(start = 0) "Reference mass flow rate"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.m_flow_set)));

protected
Expand Down
8 changes: 4 additions & 4 deletions ThermofluidStream/Undirected/FlowControl/BasicControlValve.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ model BasicControlValve "Basic valve model with optional flow characteristics fo
parameter FlowCoeffType flowCoefficient = FlowCoeffType.Kvs "Select type of flow coefficient"
annotation(Dialog(group = "Valve parameters"));
//Reference Values
parameter Real Kvs(unit = "m3/h") "Kvs-value (metric) from data sheet (valve fully open)"
parameter Real Kvs(unit = "m3/h", start = 0) "Kvs-value (metric) from data sheet (valve fully open)"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.Kvs)));
parameter Real Cvs_US "Cvs-value (US [gal/min]) from data sheet (valve fully open)"
parameter Real Cvs_US(start = 0) "Cvs-value (US [gal/min]) from data sheet (valve fully open)"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.Cvs_US)));
parameter Real Cvs_UK "Cvs-value (UK [gal/min]) from data sheet (valve fully open)"
parameter Real Cvs_UK(start = 0) "Cvs-value (UK [gal/min]) from data sheet (valve fully open)"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.Cvs_UK)));
parameter SI.MassFlowRate m_flow_ref_set "Set reference mass flow in kg/s"
parameter SI.MassFlowRate m_flow_ref_set(start = 0) "Set reference mass flow in kg/s"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.m_flow_set)));

protected
Expand Down
10 changes: 5 additions & 5 deletions ThermofluidStream/Undirected/FlowControl/SpecificValveType.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@ model SpecificValveType "Specific technical valve types"
parameter FlowCoeffType flowCoefficient = FlowCoeffType.Kvs "Select type of flow coefficient"
annotation(Dialog(group = "Valve parameters"));
//Set valve data as parameter
parameter Modelica.Units.SI.Diameter d_valve "Flow diameter"
parameter Modelica.Units.SI.Diameter d_valve(start = 0) "Flow diameter"
annotation (Evaluate=true, Dialog(group="Valve parameters", enable=(flowCoefficient== FlowCoeffType.flowDiameter)));
//Reference Values
parameter Real Kvs(unit = "m3/h") "Kvs-value (metric) from data sheet (valve fully open)"
parameter Real Kvs(unit = "m3/h", start = 0) "Kvs-value (metric) from data sheet (valve fully open)"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.Kvs)));
parameter Real Cvs_US "Cvs-value (US [gal/min]) from data sheet (valve fully open)"
parameter Real Cvs_US(start = 0) "Cvs-value (US [gal/min]) from data sheet (valve fully open)"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.Cvs_US)));
parameter Real Cvs_UK "Cvs-value (UK [gal/min]) from data sheet (valve fully open)"
parameter Real Cvs_UK(start = 0) "Cvs-value (UK [gal/min]) from data sheet (valve fully open)"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.Cvs_UK)));
parameter SI.MassFlowRate m_flow_ref_set "Set reference mass flow in kg/s"
parameter SI.MassFlowRate m_flow_ref_set(start = 0) "Set reference mass flow in kg/s"
annotation(Evaluate = true, Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.m_flow_set)));

protected
Expand Down
Loading