Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit start = 0 modifiers to parameters without default binding #187

Closed
wants to merge 1 commit into from

Conversation

casella
Copy link

@casella casella commented Jun 18, 2024

This fixes #171.

@dzimmer
Copy link
Contributor

dzimmer commented Jul 3, 2024

Will be substituted by a PR on #171 from @tobolar. (see discussion)
Thank you for suggesting a first solutions and make us think about it.

@dzimmer dzimmer closed this Jul 3, 2024
@casella
Copy link
Author

casella commented Jul 3, 2024

Not sure #171 is good either, see comment.

@dzimmer dzimmer reopened this Jul 3, 2024
@dzimmer
Copy link
Contributor

dzimmer commented Jul 3, 2024

I will not accept this PR as is but your latest suggestion of #171 with the assert statement seems good to me.
I have reopened this PR in case you want to do the changes. I can do it as well but I won't do it before Friday. Now I feel my jetlag. I fail to write English... I shall not code Modelica...

@dzimmer
Copy link
Contributor

dzimmer commented Jul 11, 2024

substituted by #201 according to discussion in #171

@dzimmer dzimmer closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants