Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce only #479

Open
3 tasks done
c40003141 opened this issue Dec 23, 2023 · 1 comment
Open
3 tasks done

reduce only #479

c40003141 opened this issue Dec 23, 2023 · 1 comment
Assignees

Comments

@c40003141
Copy link
Contributor

c40003141 commented Dec 23, 2023

  • TP/SL --> ensure that they are posted as reduce-only orders // only on line 269 & 287 of ActionBlock? What about modifications through position table
  • if reduce-only box is ticked by user for limit & stop orders, disable the option to choose TP and SL orders (none is selected by default and cannot be changed)
  • - update "exceeding" logic for the case where (combined) order size > position size:
    a) if 1 reduce-only order with order size > pos size --> show price (instead of exceeding),
    b) if multiple reduce-only orders with combined order size > pos size --> show "multiple" (instead of exceeding) ,
    c) if multiple orders (reduce-only and normal) with combine order size > pos size, check if min(combined reduce-only order size, pos size) + normal-order-size > pos. size --> if true show "exceeding", if = pos.size, show "multiple" (if > pos size, continue to show partial).
@viktors-ovcinnikovs-verum
Copy link
Collaborator

PR: #481

viktors-ovcinnikovs-verum added a commit that referenced this issue Dec 23, 2023
# Conflicts:
#	public/locales/cn/translations.json
viktors-ovcinnikovs-verum added a commit that referenced this issue Dec 23, 2023
* #473 Add min position text for PositionTooSmall

* #473 Add info about existing TP/SL open orders

* translations

* #473 Fix translation for LiFi button

* translations

* #479 Disable TP/SL blocks in case of reduce only enabled

* #479 Mark TP/SL orders with `reduceOnly: true` flag

* update TP/SL display logic taking reduce-only into account

* #479 Add `Reduce Only` column for Open Orders table

* #479 Improve logic conditions for TP/SL

* add translations

---------

Co-authored-by: c40003141 <[email protected]>
Co-authored-by: c40003141 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants