Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements #473

Open
4 tasks done
c40003141 opened this issue Dec 22, 2023 · 0 comments
Open
4 tasks done

improvements #473

c40003141 opened this issue Dec 22, 2023 · 0 comments
Assignees
@viktors-ovcinnikovs-verum @c40003141

Comments

@c40003141
Copy link
Contributor

c40003141 commented Dec 22, 2023 •
edited by viktors-ovcinnikovs-verum
Loading

  • If the user has an existing open position with existing SL/TP orders, and the user submits a new order, the review order popup should show a sentence "Verify your existing TP/SL orders - you are modifying an existing position that has TP/SL orders"
  • liquidity provision: if button is disabled, add tooltip
  • trade button: if button is disabled - add tooltip
  • position size too small: add min size in tooltip
  • [ ]
viktors-ovcinnikovs-verum added a commit that referenced this issue Dec 22, 2023
@viktors-ovcinnikovs-verum
#473 Add min position text for PositionTooSmall
5f33fad
viktors-ovcinnikovs-verum added a commit that referenced this issue Dec 22, 2023
@viktors-ovcinnikovs-verum
#473 Add info about existing TP/SL open orders
89868bb
viktors-ovcinnikovs-verum added a commit that referenced this issue Dec 23, 2023
@viktors-ovcinnikovs-verum
#473 Fix translation for LiFi button
2d8fdb2
c40003141 added a commit that referenced this issue Dec 23, 2023
@viktors-ovcinnikovs-verum @c40003141
#473 Add min position text for PositionTooSmall (#478)
17f1460 
* #473 Add min position text for PositionTooSmall

* #473 Add info about existing TP/SL open orders

* translations

* #473 Fix translation for LiFi button

* translations

* chinese translation

---------

Co-authored-by: c40003141 <[email protected]>
viktors-ovcinnikovs-verum added a commit that referenced this issue Dec 23, 2023
@viktors-ovcinnikovs-verum @c40003141
#479 Disable TP/SL blocks in case of reduce only enabled (#481)
9fbcf18 
* #473 Add min position text for PositionTooSmall

* #473 Add info about existing TP/SL open orders

* translations

* #473 Fix translation for LiFi button

* translations

* #479 Disable TP/SL blocks in case of reduce only enabled

* #479 Mark TP/SL orders with `reduceOnly: true` flag

* update TP/SL display logic taking reduce-only into account

* #479 Add `Reduce Only` column for Open Orders table

* #479 Improve logic conditions for TP/SL

* add translations

---------

Co-authored-by: c40003141 <[email protected]>
Co-authored-by: c40003141 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viktors-ovcinnikovs-verum viktors-ovcinnikovs-verum

@c40003141 c40003141

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viktors-ovcinnikovs-verum @c40003141