Rewrite and simplify crates.io publishing actions #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey "Shnatsel" Davidoff <[email protected]>
Signed-off-by: Sergey "Shnatsel" Davidoff <[email protected]>
Signed-off-by: Sergey "Shnatsel" Davidoff <[email protected]>
|
I've tested this on a fork but it didn't have a token so I can only be sure this triggers correctly on a tag, and not about any of the more involved stuff. But it's still |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the workflow to be triggered by a tag, rather than create a tag automatically. We need the tag to be created by a human rather than by Github Actions so that cargo-dist workflows that publish binaries would work properly. (I had to do some manual fixup to build binaries for the latest release).
This also removes the
--allow-dirtyflag that prevents attribution to a specific commit and is known to cause issues for links in the way our documentation shows up on crates.io, previously attempted in #719Drops cache because the check before publishing uses latest versions from crates.io rather than what we have in Cargo.lock, so caching isn't do much there. Also, clean builds have less of a risk of running into incremental compilation bugs in the compiler, and we run this workflow rarely enough that execution time is not a concern.