Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --allow-dirty option (v2) … #719

Closed
wants to merge 1 commit into from
Closed

Remove --allow-dirty option (v2) … #719

wants to merge 1 commit into from

Conversation

Olf0
Copy link

@Olf0 Olf0 commented May 25, 2024 •
edited
Loading

… from cargo publish calls in the CI/CD workflows, because this option prevents creating a .cargo_vcs_info.json file. This should (really) close rust-lang/crates.io#8551, see there for details.
Now a cargo package with --allow-dirty executes all steps a cargo publish does except publishing, then the changes are committed back to the git repo and lastly cargo publish is run; for details see last paragraph of #702 (comment).

Supersedes PR #702

Signed-off-by: olf [email protected]

@Olf0
Remove --allow-dirty option (v2) …
68e0089 
* [deploy_cargo_cyclonedx.yml] Remove `--allow-dirty` option …
  … from `cargo publish` call and expand CI step names.  This should (really) close rust-lang/crates.io#8551 , see there for details.
  Signed-off-by: olf <[email protected]>

* [deploy_cyclonedx_bom.yml] Remove `--allow-dirty` option …
  … from `cargo publish` call and expand CI step names.  This should (really) close rust-lang/crates.io#8551 , see there for details.
  Signed-off-by: olf <[email protected]>

---------

Signed-off-by: olf <[email protected]>
@Olf0 Olf0 requested a review from a team as a code owner May 25, 2024 02:14
@Olf0 Olf0 mentioned this pull request May 25, 2024
Closed
@Shnatsel
Copy link
Contributor

My comments from the previous iteration still apply: #718 (comment)

@Olf0
Copy link
Author

Olf0 commented May 25, 2024

My comments from the previous iteration still apply: #718 (comment)

So do my checks & balances questions I compiled there meanwhile: #718 (comment)

@Shnatsel Shnatsel mentioned this pull request Jun 3, 2024
Merged
@Shnatsel
Copy link
Contributor

Shnatsel commented Jun 4, 2024

The --allow-dirty flag was removed in #724, so I understand this is no longer necessary?

@Olf0
Copy link
Author

Olf0 commented Jun 4, 2024 •
edited
Loading

The --allow-dirty flag was removed in #724, so I understand this is no longer necessary?

I assumed so, but when retesting the original issue it still does not work.

Please note that also a trivial, quick&dirty workaround exists, as denoted in #702 (comment).

@Shnatsel
Copy link
Contributor

Shnatsel commented Jun 4, 2024

I've just published a new release without --allow-dirty and the "contributing" link on https://crates.io/crates/cargo-cyclonedx works for me now.

Is there some other link that's broken that I am missing?

@Olf0
Copy link
Author

Olf0 commented Jun 4, 2024

I've just published a new release without --allow-dirty and the "contributing" link on https://crates.io/crates/cargo-cyclonedx works for me now.

Retested: Ack

Is there some other link that's broken that I am missing?

Nope, I assume I tested it before you published the new release.

@Olf0 Olf0 closed this Jun 4, 2024
@Olf0 Olf0 deleted the remove_--allow-dirty_v2 branch June 4, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken CONTRIBUTING link for crate cargo-cyclonedx
2 participants
@Olf0 @Shnatsel